Bug 152318 - Get rid of WebDatabaseManager, it's been replaced by WebsiteDataStore
Summary: Get rid of WebDatabaseManager, it's been replaced by WebsiteDataStore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 152460
Blocks:
  Show dependency tree / graph
 
Reported: 2015-12-15 17:08 PST by Anders Carlsson
Modified: 2015-12-19 09:37 PST (History)
7 users (show)

See Also:

Attachments
Patch (82.48 KB, patch)
2015-12-15 17:10 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (874.42 KB, application/zip)
2015-12-15 18:07 PST, Build Bot 		no flags Details
Patch (82.95 KB, patch)
2015-12-16 10:21 PST, Anders Carlsson 		thorton: review+
Details | Formatted Diff | Diff
Patch (2.70 KB, patch)
2015-12-16 11:15 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-12-15 17:08:35 PST 
Get rid of WebDatabaseManager, it's been replaced by WebsiteDataStore
Comment 1 Anders Carlsson 2015-12-15 17:10:25 PST 
Created attachment 267414 [details]
Patch
Comment 2 Build Bot 2015-12-15 18:07:32 PST 
Comment on attachment 267414 [details]
Patch

Attachment 267414 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/564670

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2015-12-15 18:07:34 PST 
Created attachment 267415 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 4 Anders Carlsson 2015-12-16 10:21:44 PST 
Created attachment 267465 [details]
Patch
Comment 5 Csaba Osztrogonác 2015-12-16 11:15:45 PST 
Created attachment 267474 [details]
Patch

cmake buildsystem fix, please integrate it before landing.
Comment 6 Csaba Osztrogonác 2015-12-16 11:17:59 PST 
WKDataBaseManager is still used by EFL port, so it will break the build.
Comment 7 Anders Carlsson 2015-12-18 14:27:40 PST 
(In reply to comment #6)
> WKDataBaseManager is still used by EFL port, so it will break the build.

Yup, they're going to have to switch over to WebsiteDataStore. I'll make sure to land your build fix.
Comment 8 Anders Carlsson 2015-12-18 14:35:15 PST 
Committed r194295: <http://trac.webkit.org/changeset/194295>