Bug 152197 – [MediaStream] Add a setting to allow the mock media capture devices to be enabled and disabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Add a setting to allow the mock media capture devices to be enabled and disabled

[Eric Carlson]

Created attachment 267201 [details]
Proposed patch.

[Dean Jackson]

Comment on attachment 267201 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=267201&action=review

> Source/WebKit2/UIProcess/API/C/WKPreferences.cpp:1432
> -void WKPreferencesSetResourceUsageOverlayVisible(WKPreferencesRef preferencesRef, bool javaEnabled)
> +void WKPreferencesSetResourceUsageOverlayVisible(WKPreferencesRef preferencesRef, bool enabled)
>  {
> -    toImpl(preferencesRef)->setResourceUsageOverlayVisible(javaEnabled);
> +    toImpl(preferencesRef)->setResourceUsageOverlayVisible(enabled);

Nice!

> LayoutTests/fast/mediastream/mock-media-source.html:17
> +                debug(`<br>*** Disable mock capture devices`);
> +                if (window.internals)
> +                    evalAndLog(`internals.setMockMediaCaptureDevicesEnabled(false)`);
> +                navigator.mediaDevices
> +                    .getUserMedia({audio:{}, video:{}})
> +                    .then(function(stream) {
> +                        mediaStream = stream;
> +                        testFailed(`mediaDevices.getUserMedia() succeeded when no devices should be available`);

Not a suggestion to fix, but I don't like the way the backtick looks, so I use regular quotes if I don't have any of the ${} stuff.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 267201 [details]:

transitions/default-timing-function.html bug 138901 (author: [e-mail])
http/tests/media/media-source/mediasource-append-buffer.html bug 152206 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 267201 [details]
Proposed patch.

Clearing flags on attachment: 267201

Committed r194000: <http://trac.webkit.org/changeset/194000>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.