Bug 152076 – Web Inspector: zoom with Ctrl +/- doesn't work correctly when inspector is docked

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

From a comment in bug 149590:

If the Developer tools are docked at the bottom of my browser and I'm either zoomed-in or out and then I try to resize the Dev Tools vertically by pulling it up or down, it doesn't work at all. If I restore Dev Tools to their original resolution by typing Command-0, then yes I can resize the tools vertically without any issues.

I've included a brief "steps to reproduce" list below:

1. Bring up the Developer Tools in Webkit.
2. Make sure that they are docked at the bottom of the browser window.
3. Either zoom in or out of the Developer tools.
4. Attempt to resize Developer Tools by dragging its top menu bar either upwards or downwards.

Expected Results:
The Developer Tools would resize vertically.

Actual Result:
Developer Tools do not resize, in fact opposite behaviour was observed whereby they shrinked vertically when the user attempted to lengthen them vertically.

[Radar WebKit Bug Importer]

<rdar://problem/23823393>

[Blaze Burg]

Created attachment 267027 [details]
Proposed Fix

[Joseph Pecoraro]

Comment on attachment 267027 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=267027&action=review

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:145
> +    if (self.ignoreNextViewFrameDidChangeNotification) {
> +        self.ignoreNextViewFrameDidChangeNotification = NO;
> +        return;
> +    }

Matt recently removed something like this. Check with him to see if he has a counter-example for why this may not be correct.

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:727
> +    [m_inspectorProxyObjCAdapter.get() setIgnoreNextViewFrameDidChangeNotification:YES];

I think the `.get()` is actually not needed here, due to magic.

[Blaze Burg]

Comment on attachment 267027 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=267027&action=review

>> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:145
>> +    }
> 
> Matt recently removed something like this. Check with him to see if he has a counter-example for why this may not be correct.

You are right. I'll revert it. https://bugs.webkit.org/show_bug.cgi?id=146994

[Blaze Burg]

Created attachment 267034 [details]
Proposed Fix (simpler)

[WebKit Commit Bot]

Comment on attachment 267034 [details]
Proposed Fix (simpler)

Clearing flags on attachment: 267034

Committed r193858: <http://trac.webkit.org/changeset/193858>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Nikita Vasilyev]

*** Bug 149946 has been marked as a duplicate of this bug. ***