Bug 146994 – [Mac] Web Inspector toolbar can be covered by the Safari tab bar when docked to the right

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Matt Baker]

* SUMMARY
Web Inspector toolbar can be covered by the Safari tab bar when docked to the right.

* STEPS TO REPRODUCE
1. Open Safari, dock Inspector on right.
2. Create a new tab.
3. Switch back to tab containing the docked Inspector.
4. Close second tab.
5. Repeat steps 2 & 3.
  => Safari switches back to first tab, and Inspector toolbar is covered by tab bar.

[Matt Baker]

Created attachment 256886 [details]
[Image] Covered toolbar

[Matt Baker]

<rdar://problem/21669802>

[Matt Baker]

Created attachment 256887 [details]
[Patch] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 256887 [details]
[Patch] Proposed Fix

Looks good to me. I tested briefly and didn't see any issues after removing this code. I cannot remember why this was added, I wonder if it was just performance. Needs a WK2 Owner nod.

[Brian Burg]

Comment on attachment 256887 [details]
[Patch] Proposed Fix

That code was added in the change to have a separate inspector process, to avoid recursively triggering -(void)inspectedViewFrameDidChange when adjusting docked size. It might have been made unnecessary with the switch to WKWebView, since the current code tries to only listen for viewFrameDidChange of the single active parent frame.

[WebKit Commit Bot]

Comment on attachment 256887 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 256887

Committed r186924: <http://trac.webkit.org/changeset/186924>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.