Bug 151855 - [AArch64] Typo fix after r189575
Summary: [AArch64] Typo fix after r189575
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 108645 148666
  Show dependency tree / graph
 
Reported: 2015-12-04 03:17 PST by Csaba Osztrogonác
Modified: 2015-12-04 05:01 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2015-12-04 03:19 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-12-04 03:17:25 PST 
There is a typo introduced in http://trac.webkit.org/changeset/189575/trunk/Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp

case UNW_ARM64_v21 should be changed to match to other places

-                append(RegisterAtOffset(ARM64Registers::q21, prolog.savedRegisters[i].offset + prolog.cfaRegisterOffset));
+                registerOffsets->append(RegisterAtOffset(ARM64Registers::q21, prolog.savedRegisters[i].offset + prolog.cfaRegisterOffset));

We need this to fix the FTL build on AArch64.
Comment 1 Csaba Osztrogonác 2015-12-04 03:19:09 PST 
Created attachment 266615 [details]
Patch
Comment 2 Michael Saboff 2015-12-04 04:14:06 PST 
Comment on attachment 266615 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2015-12-04 05:01:24 PST 
Comment on attachment 266615 [details]
Patch

Clearing flags on attachment: 266615

Committed r193414: <http://trac.webkit.org/changeset/193414>
Comment 4 WebKit Commit Bot 2015-12-04 05:01:33 PST 
All reviewed patches have been landed.  Closing bug.