Bug 151611 - [ARMv7] Some JSC test fails due to exhausting the JIT code heap on the no LLINT test configuration.
Summary: [ARMv7] Some JSC test fails due to exhausting the JIT code heap on the no LLI...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on: 154392
Blocks: 108645
  Show dependency treegraph
 
Reported: 2015-11-25 13:26 PST by Mark Lam
Modified: 2016-02-18 04:11 PST (History)
10 users (show)

See Also:


Attachments
proposed patch. (7.02 KB, patch)
2016-02-15 20:26 PST, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-11-25 13:26:20 PST
The following JSC stress test failures have been introduced recently:
	jsc-layout-tests.yaml/js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js.layout-no-llint
	jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint

I saw this when I tested with r192767.
Comment 1 Radar WebKit Bug Importer 2015-11-30 12:16:27 PST
<rdar://problem/23692532>
Comment 2 Mark Lam 2016-02-15 14:48:31 PST
With r196590, the following tests are also now failing:
	jsc-layout-tests.yaml/js/script-tests/dfg-float32array.js.layout-no-llint
	jsc-layout-tests.yaml/js/script-tests/dfg-float64array.js.layout-no-llint
	jsc-layout-tests.yaml/js/script-tests/dfg-int16array.js.layout-no-llint
	jsc-layout-tests.yaml/js/script-tests/dfg-int32array-overflow-values.js.layout-no-llint
	jsc-layout-tests.yaml/js/script-tests/dfg-int32array.js.layout-no-llint
	jsc-layout-tests.yaml/js/script-tests/dfg-int8array.js.layout-no-llint
	jsc-layout-tests.yaml/js/script-tests/dfg-uint16array.js.layout-no-llint
	jsc-layout-tests.yaml/js/script-tests/dfg-uint32array-overflow-values.js.layout-no-llint
	jsc-layout-tests.yaml/js/script-tests/dfg-uint32array.js.layout-no-llint
	jsc-layout-tests.yaml/js/script-tests/dfg-uint8array.js.layout-no-llint
	jsc-layout-tests.yaml/js/script-tests/dfg-uint8clampedarray.js.layout-no-llint

All of these tests are failing on the no LLINT configuration.
Comment 3 Mark Lam 2016-02-15 16:05:49 PST
AFAICT, these tests are only failing because they are compiling too much with the LLINT disabled.  As a result, they are using more JIT code heap space than is allowed by the OS.

I'm looking into excluding these tests on the noLLINT configuration on ARMv7.
Comment 4 Mark Lam 2016-02-15 20:26:02 PST
Created attachment 271408 [details]
proposed patch.
Comment 5 Mark Lam 2016-02-15 20:27:22 PST
I've verified that this patch only excludes the noLLInt configuration on 32-bit arm.  It still runs that configuration on arm64.
Comment 6 WebKit Commit Bot 2016-02-15 23:10:10 PST
Comment on attachment 271408 [details]
proposed patch.

Clearing flags on attachment: 271408

Committed r196625: <http://trac.webkit.org/changeset/196625>
Comment 7 WebKit Commit Bot 2016-02-15 23:10:15 PST
All reviewed patches have been landed.  Closing bug.