Bug 151572 - Web Inspector: use Cmd-Option-L and Cmd-Option-R for toggling navigation and details sidebars
Summary: Web Inspector: use Cmd-Option-L and Cmd-Option-R for toggling navigation and ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks: 151237
  Show dependency tree / graph
 
Reported: 2015-11-23 14:01 PST by BJ Burg
Modified: 2015-11-28 15:23 PST (History)
8 users (show)

See Also:

Attachments
Proposed Fix (2.96 KB, patch)
2015-11-23 14:03 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2015-11-23 14:01:07 PST 
We currently use Cmd-0 and Cmd-Option-0, but these don't match Safari's shortcuts and conflict with Cmd-0 as "Reset Page Zoom".
Comment 1 Radar WebKit Bug Importer 2015-11-23 14:01:20 PST 
<rdar://problem/23650902>
Comment 2 BJ Burg 2015-11-23 14:03:56 PST 
Created attachment 266098 [details]
Proposed Fix
Comment 3 WebKit Commit Bot 2015-11-23 18:43:44 PST 
Comment on attachment 266098 [details]
Proposed Fix

Clearing flags on attachment: 266098

Committed r192755: <http://trac.webkit.org/changeset/192755>
Comment 4 WebKit Commit Bot 2015-11-23 18:43:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Nikita Vasilyev 2015-11-27 20:33:22 PST 
Command-Option-R toggles responsive design mode in Safari.
Now, pressing Command-Option-R once enters responsive design mode.
Pressing it again, toggles the right sidebar.
https://cloudup.com/c-qJT91xLhK
Comment 6 BJ Burg 2015-11-28 15:23:39 PST 
(In reply to comment #5)
> Command-Option-R toggles responsive design mode in Safari.
> Now, pressing Command-Option-R once enters responsive design mode.
> Pressing it again, toggles the right sidebar.
> https://cloudup.com/c-qJT91xLhK

This looks like a focus bug. It doesn't reproduce when Inspector has its own window. When inspector is docked and the main page focused, the shortcut opens RDM and focuses the Web Inspector. It should keep focus when changing into or out of RDM. Can you file a radar about this? It isn't clear whether it's a WebKit or Safari bug.