Bug 151237 – Web Inspector: Add a keyboard shortcut to restore the default zoom level

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Command +/- in Safari and WebKit Inspector increases and decreases the zoom level respectively.
Command 0 in Safari resets the zoom level.
Command 0 in Web Inspector toggles the left sidebar.

[Radar WebKit Bug Importer]

<rdar://problem/23527493>

[Blaze Burg]

Cmd-0 is bound to show/hide main navigator in Xcode, which is how it got into Inspector. However, I think we should be consistent with Safari and other browsers and use Cmd-0 to reset the zoom level. Safari uses Cmd-Shift-L to toggle the left sidebar, I'm fine with that. Would probably want Cmd-Shift-R for the right sidebar, then.

[Nikita Vasilyev]

(In reply to comment #2)
> Cmd-0 is bound to show/hide main navigator in Xcode, which is how it got
> into Inspector. However, I think we should be consistent with Safari and
> other browsers and use Cmd-0 to reset the zoom level. Safari uses
> Cmd-Shift-L to toggle the left sidebar, I'm fine with that. Would probably
> want Cmd-Shift-R for the right sidebar, then.

Cmd-Shift-R already reloads ignoring cache in Web Inspector and Chrome.
https://www.webkit.org/blog-files/web-inspector-keyboard-shortcuts/tooltips.gif

[Blaze Burg]

Created attachment 266099 [details]
Proposed Fix

[Blaze Burg]

(In reply to comment #3)
> (In reply to comment #2)
> > Cmd-0 is bound to show/hide main navigator in Xcode, which is how it got
> > into Inspector. However, I think we should be consistent with Safari and
> > other browsers and use Cmd-0 to reset the zoom level. Safari uses
> > Cmd-Shift-L to toggle the left sidebar, I'm fine with that. Would probably
> > want Cmd-Shift-R for the right sidebar, then.
> 
> Cmd-Shift-R already reloads ignoring cache in Web Inspector and Chrome.
> https://www.webkit.org/blog-files/web-inspector-keyboard-shortcuts/tooltips.
> gif

I meant Cmd-Option-{R,L}, sorry.

[WebKit Commit Bot]

Comment on attachment 266099 [details]
Proposed Fix

Clearing flags on attachment: 266099

Committed r192757: <http://trac.webkit.org/changeset/192757>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

Comment on attachment 266099 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=266099&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:1851
> +    event.preventDefault();

Is this needed? I think KeyboardShortcut implicitly prevents default by default.