Bug 151567 – REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Renata Hodovan]

Open www.google.com with MiniBrowser (debug or release) and try to close it with the close-window button in the corner. With an EFL build nothing happens for me (i.e. the window does not close). Could somebody test it with another port too?

[Blaze Burg]

This does not seem to reproduce on Mac. Changing platform to EFL for now.

[Gyuyoung Kim]

This bug looks a regression.

[Gyuyoung Kim]

Created attachment 266120 [details]
Patch

[Hunseop Jeong]

Comment on attachment 266120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266120&action=review

> Tools/MiniBrowser/efl/main.c:2040
> +    window_close(window_find_with_elm_window(elm_window));

If we don't use the parameters (user_data, event_info), how about removing them?

[Gyuyoung Kim]

Created attachment 266121 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 266120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266120&action=review

>> Tools/MiniBrowser/efl/main.c:2040
>> +    window_close(window_find_with_elm_window(elm_window));
> 
> If we don't use the parameters (user_data, event_info), how about removing them?

It is not huge related with this fix though, let's remove unused parameters as well.

[Gyuyoung Kim]

Created attachment 266124 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #4)
> Comment on attachment 266120 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266120&action=review
> 
> > Tools/MiniBrowser/efl/main.c:2040
> > +    window_close(window_find_with_elm_window(elm_window));
> 
> If we don't use the parameters (user_data, event_info), how about removing
> them?

EFL MiniBrowser is C, not C++. So we can't omit parameter.

http://stackoverflow.com/questions/8776810/parameter-name-omitted-c-vs-c

[Hunseop Jeong]

(In reply to comment #8)
> (In reply to comment #4)
> > Comment on attachment 266120 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=266120&action=review
> > 
> > > Tools/MiniBrowser/efl/main.c:2040
> > > +    window_close(window_find_with_elm_window(elm_window));
> > 
> > If we don't use the parameters (user_data, event_info), how about removing
> > them?
> 
> EFL MiniBrowser is C, not C++. So we can't omit parameter.
> 
> http://stackoverflow.com/questions/8776810/parameter-name-omitted-c-vs-c

Okay,, I just worry about some warning occur case like as c++.
Thanks for the information.

[WebKit Commit Bot]

Comment on attachment 266124 [details]
Patch

Clearing flags on attachment: 266124

Committed r192767: <http://trac.webkit.org/changeset/192767>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryuan Choi]

(In reply to comment #11)
> All reviewed patches have been landed.  Closing bug.

Sorry for the late answer.
I made a Bug 151934 to fix this regression.