Bug 151934 - [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
Summary: [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-07 02:17 PST by Ryuan Choi
Modified: 2015-12-07 03:46 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.67 KB, patch)
2015-12-07 02:44 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2015-12-07 02:17:25 PST 
Bug 151567 reported the regression of r192053(In fact, it's the regression since r192528)

It's because tryClose() returned immediately without calling close callback when the page does not have onbeforeunload callback since r192528.
Comment 1 Ryuan Choi 2015-12-07 02:44:03 PST 
Created attachment 266761 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-12-07 02:51:38 PST 
Comment on attachment 266761 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2015-12-07 03:46:47 PST 
Comment on attachment 266761 [details]
Patch

Clearing flags on attachment: 266761

Committed r193619: <http://trac.webkit.org/changeset/193619>
Comment 4 WebKit Commit Bot 2015-12-07 03:46:51 PST 
All reviewed patches have been landed.  Closing bug.