Bug 151431 – Add WebCore namespace for generated bindings for supplemental method calls

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Nikos Andronikos]

This patch adds "WebCore::" to supplemental method calls for bindings code generated for JS and Objective-C.
This will solve a build failure we have observed while trying to add a partial interface Document binding for the Web Animation API implementation.

[Nikos Andronikos]

Created attachment 265845 [details]
Patch

[Alex Christensen]

What is the build failure?  What does the generated code look like?  Is it calling WebCore namespace code from a namespace inside WebCore?  I would believe this change is necessary, but I'd like a little more info.

[Darin Adler]

Comment on attachment 265845 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265845&action=review

> Source/WebCore/ChangeLog:3
> +        Add WebCore namespace for generated bindings for supplemental method calls

Why?

[Nikos Andronikos]

(In reply to comment #2)
> What is the build failure?  What does the generated code look like?  Is it
> calling WebCore namespace code from a namespace inside WebCore?  I would
> believe this change is necessary, but I'd like a little more info.

The build failure is that the namespace “WebCore::” is missing before the class name.  A little background of what I am implementing:

I am implementing a partial interface extension to the “Document” interface using "Supplement" (see “Supplementable.h”).

The generated code is output into DOMDocument.mm and looks like this:
  
- (DOMDocumentTimeline *)timeline
 {
     WebCore::JSMainThreadNullState state;
     return kit(WTF::getPtr(DocumentAnimation::timeline(IMPL)));
}
  
The compiler complains that “DocumentAnimation” cannot be resolved, because “WebCore::” is missing.  My fix corrects this by adding the namespace to “DocumentAnimation”.
  
Note: It looks to me like the lack of the WebCore namespace specifier was an oversight by the author of the supplemental interface changes. He seems to have corrected that oversight for GObject (see: https://bugs.webkit.org/show_bug.cgi?id=79293), but not here. I presume no code has been generated that has hit this before.

[Nikos Andronikos]

Created attachment 266073 [details]
Patch

[Nikos Andronikos]

(In reply to comment #3)
> Comment on attachment 265845 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265845&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Add WebCore namespace for generated bindings for supplemental method calls
> 
> Why?

See updated patch

[WebKit Commit Bot]

Comment on attachment 266073 [details]
Patch

Clearing flags on attachment: 266073

Committed r192750: <http://trac.webkit.org/changeset/192750>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.