Bug 79293 - Enable Geolocation bindings for GObject
Summary: Enable Geolocation bindings for GObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 79327
  Show dependency treegraph
 
Reported: 2012-02-22 16:05 PST by Adam Barth
Modified: 2012-02-23 20:58 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.35 KB, patch)
2012-02-22 16:06 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (5.49 KB, patch)
2012-02-22 20:56 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-02-22 16:05:26 PST
Enable Geolocation bindings for GObject
Comment 1 Adam Barth 2012-02-22 16:06:05 PST
Created attachment 128316 [details]
Patch
Comment 2 Kentaro Hara 2012-02-22 16:09:47 PST
Try to see if the GTK bot gets happy.
Comment 3 Philippe Normand 2012-02-22 16:31:36 PST
Comment on attachment 128316 [details]
Patch

Attachment 128316 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11599019
Comment 4 Kentaro Hara 2012-02-22 16:32:18 PST
:-(
Comment 5 Adam Barth 2012-02-22 16:35:37 PST
Comment on attachment 128316 [details]
Patch

I'm not sure it's the same problem that mrobinson fixed.  It might just be a bug somewhere in the code generator where the include line isn't being generated for some reason.
Comment 6 Martin Robinson 2012-02-22 17:38:41 PST
This failure seems unrelated to the bug I was looking at.
Comment 7 Martin Robinson 2012-02-22 17:40:18 PST
Do take care when making changes that break API on GTK+. We just branched for a stable release a few days ago and if Geolocation was disabled there, we may have shipped a pre-release with an API break.
Comment 8 Adam Barth 2012-02-22 17:44:00 PST
Hopefully we will get this fixed shortly.  The breaking half of this change when in less than 24 hours ago.  With any luck, we'll resolve the issue within another 24 hours.
Comment 9 Martin Robinson 2012-02-22 17:48:04 PST
(In reply to comment #8)
> Hopefully we will get this fixed shortly.  The breaking half of this change when in less than 24 hours ago.  With any luck, we'll resolve the issue within another 24 hours.

If it was only 24-hours ago, everything should be fine then. We branched before that point. :)
Comment 10 Kentaro Hara 2012-02-22 20:48:50 PST
I tried the GTK build in my local machine and found that "WebCore::" is missing before "NavigatorGeolocation":-)

Patch is coming.
Comment 11 Kentaro Hara 2012-02-22 20:56:19 PST
Created attachment 128381 [details]
Patch
Comment 12 Kentaro Hara 2012-02-22 21:05:20 PST
The GTK bot looks happy:)
Comment 13 Adam Barth 2012-02-22 21:41:41 PST
Comment on attachment 128381 [details]
Patch

Ah!
Comment 14 WebKit Review Bot 2012-02-22 22:25:54 PST
Comment on attachment 128381 [details]
Patch

Clearing flags on attachment: 128381

Committed r108610: <http://trac.webkit.org/changeset/108610>
Comment 15 WebKit Review Bot 2012-02-22 22:25:59 PST
All reviewed patches have been landed.  Closing bug.