Bug 151424 - Web Inspector: move cookie url matching out of CookieStorageContentView and clean up some code
Summary: Web Inspector: move cookie url matching out of CookieStorageContentView and c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks: 151413 151408
  Show dependency treegraph
 
Reported: 2015-11-18 16:33 PST by BJ Burg
Modified: 2015-11-18 22:27 PST (History)
7 users (show)

See Also:


Attachments
Proposed Fix (8.79 KB, patch)
2015-11-18 16:40 PST, BJ Burg
timothy: review+
bburg: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2015-11-18 16:33:25 PST
Factoring this away from behavior changes so the test can be added with the behavior change it tests.
Comment 1 Radar WebKit Bug Importer 2015-11-18 16:33:48 PST
<rdar://problem/23603756>
Comment 2 BJ Burg 2015-11-18 16:40:57 PST
Created attachment 265808 [details]
Proposed Fix
Comment 3 Timothy Hatcher 2015-11-18 21:01:31 PST
Comment on attachment 265808 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=265808&action=review

> Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:50
> +        .then((payload) => {

One line please.

> Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:54
> +        .catch((error) => {

Ditto. These really looks weird.

> Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:159
> +            // The main resource isn't always in the list of resources, make sure to add it as a candidate.

It never is.
Comment 4 BJ Burg 2015-11-18 22:27:24 PST
Committed r192614: <http://trac.webkit.org/changeset/192614>