Bug 151029 - iOS should build with USE(CFNETWORK)
Summary: iOS should build with USE(CFNETWORK)
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-09 09:00 PST by David Kilzer (:ddkilzer)
Modified: 2015-11-25 01:13 PST (History)
6 users (show)

See Also:


Attachments
Patch to find build failures; do not review (1.05 KB, patch)
2015-11-09 09:05 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v2; do not review (3.01 KB, patch)
2015-11-09 09:22 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v3; do not review (6.80 KB, patch)
2015-11-09 10:58 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v4; do not review (6.74 KB, patch)
2015-11-09 13:13 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v5; do not review (6.79 KB, patch)
2015-11-09 13:26 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v6; do not review (7.36 KB, patch)
2015-11-09 14:39 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v7; do not review (7.92 KB, patch)
2015-11-10 13:36 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v8; do not review (11.35 KB, patch)
2015-11-10 14:43 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v9; do not review (11.37 KB, patch)
2015-11-10 15:51 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v10; do not review (11.58 KB, patch)
2015-11-11 15:00 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v11; do not review (12.86 KB, patch)
2015-11-11 15:41 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v12; do not review (14.04 KB, patch)
2015-11-11 16:55 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v13; do not review (15.35 KB, patch)
2015-11-12 07:28 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v14; do not review (15.41 KB, patch)
2015-11-12 09:40 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v15; do not review (16.27 KB, patch)
2015-11-12 10:11 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v16; do not review (16.70 KB, patch)
2015-11-12 11:35 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v17; do not review (17.67 KB, patch)
2015-11-12 12:30 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v18; do not review (21.83 KB, patch)
2015-11-13 15:10 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v19; do not review (21.96 KB, patch)
2015-11-13 23:06 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v20; do not review (21.94 KB, patch)
2015-11-14 00:26 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v21; do not review (22.06 KB, patch)
2015-11-14 07:07 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v22 (24.74 KB, patch)
2015-11-16 10:44 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v23 (24.81 KB, patch)
2015-11-16 11:05 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v24 (26.75 KB, patch)
2015-11-16 14:38 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v25 (28.11 KB, patch)
2015-11-25 00:29 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch to find build failures v26 (28.73 KB, patch)
2015-11-25 01:13 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2015-11-09 09:00:22 PST
iOS should build with USE(CFNETWORK) to match what is shipped.

This will require adding a bunch of CFNetwork SPI declarations to make it build.
Comment 1 David Kilzer (:ddkilzer) 2015-11-09 09:05:07 PST
Created attachment 265057 [details]
Patch to find build failures; do not review
Comment 2 David Kilzer (:ddkilzer) 2015-11-09 09:22:24 PST
Created attachment 265060 [details]
Patch to find build failures v2; do not review
Comment 3 David Kilzer (:ddkilzer) 2015-11-09 10:58:33 PST
Created attachment 265072 [details]
Patch to find build failures v3; do not review
Comment 4 WebKit Commit Bot 2015-11-09 11:00:55 PST
Attachment 265072 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:100:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:101:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:102:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:107:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:108:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:109:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:110:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:111:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:112:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:113:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:114:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:119:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:120:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:121:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:122:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:123:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:124:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:125:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:126:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 19 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 David Kilzer (:ddkilzer) 2015-11-09 13:13:53 PST
Created attachment 265088 [details]
Patch to find build failures v4; do not review
Comment 6 WebKit Commit Bot 2015-11-09 13:15:52 PST
Attachment 265088 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:99:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:100:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:101:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:106:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:107:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:108:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:109:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:110:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:111:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:112:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:113:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:118:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:119:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:120:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:121:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:122:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:123:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:124:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:125:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 19 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 David Kilzer (:ddkilzer) 2015-11-09 13:26:03 PST
Created attachment 265091 [details]
Patch to find build failures v5; do not review
Comment 8 WebKit Commit Bot 2015-11-09 13:27:27 PST
Attachment 265091 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:100:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:101:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:102:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:107:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:108:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:109:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:110:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:111:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:112:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:113:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:114:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:119:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:120:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:121:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:122:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:123:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:124:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:125:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:126:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 19 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 David Kilzer (:ddkilzer) 2015-11-09 14:39:26 PST
Created attachment 265100 [details]
Patch to find build failures v6; do not review
Comment 10 WebKit Commit Bot 2015-11-09 14:42:34 PST
Attachment 265100 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:100:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:101:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:102:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:107:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:108:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:109:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:110:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:111:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:112:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:113:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:114:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:119:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:120:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:121:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:122:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:123:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:124:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:125:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:126:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 19 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Alexey Proskuryakov 2015-11-09 20:39:04 PST
Looks like iOS and Windows builds are broken.
Comment 12 David Kilzer (:ddkilzer) 2015-11-10 13:36:29 PST
Created attachment 265225 [details]
Patch to find build failures v7; do not review
Comment 13 WebKit Commit Bot 2015-11-10 13:38:25 PST
Attachment 265225 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:101:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:102:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:103:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:108:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:109:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:110:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:111:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:112:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:113:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:114:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:115:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:120:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:121:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:122:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:123:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:124:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:125:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:126:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:127:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 19 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 David Kilzer (:ddkilzer) 2015-11-10 14:43:29 PST
Created attachment 265235 [details]
Patch to find build failures v8; do not review
Comment 15 David Kilzer (:ddkilzer) 2015-11-10 14:45:45 PST
(In reply to comment #13)
> Attachment 265225 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:101:  enum members
> should use InterCaps with an initial capital letter. 
> [readability/enum_casing] [4]

These will stop appearing once the fix for this lands:

Bug 104417: [check-webkit-style] False positive (readability/enum_casing) on CF-styled enum members
Comment 16 WebKit Commit Bot 2015-11-10 14:46:49 PST
Attachment 265235 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:122:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:123:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:124:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:129:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:130:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:131:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:132:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:133:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:134:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:135:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:136:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:141:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:142:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:143:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:144:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:145:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:146:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:147:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cf/CFNetworkSPI.h:148:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 19 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 17 David Kilzer (:ddkilzer) 2015-11-10 15:51:56 PST
Created attachment 265239 [details]
Patch to find build failures v9; do not review
Comment 18 David Kilzer (:ddkilzer) 2015-11-11 15:00:25 PST
Created attachment 265321 [details]
Patch to find build failures v10; do not review
Comment 19 David Kilzer (:ddkilzer) 2015-11-11 15:41:54 PST
Created attachment 265324 [details]
Patch to find build failures v11; do not review
Comment 20 David Kilzer (:ddkilzer) 2015-11-11 16:55:38 PST
Created attachment 265338 [details]
Patch to find build failures v12; do not review
Comment 21 David Kilzer (:ddkilzer) 2015-11-12 07:28:30 PST
Created attachment 265389 [details]
Patch to find build failures v13; do not review
Comment 22 David Kilzer (:ddkilzer) 2015-11-12 09:40:33 PST
Created attachment 265402 [details]
Patch to find build failures v14; do not review
Comment 23 David Kilzer (:ddkilzer) 2015-11-12 10:11:52 PST
Created attachment 265404 [details]
Patch to find build failures v15; do not review
Comment 24 David Kilzer (:ddkilzer) 2015-11-12 11:35:04 PST
Created attachment 265412 [details]
Patch to find build failures v16; do not review
Comment 25 David Kilzer (:ddkilzer) 2015-11-12 12:30:13 PST
Created attachment 265420 [details]
Patch to find build failures v17; do not review
Comment 26 David Kilzer (:ddkilzer) 2015-11-13 15:10:25 PST
Created attachment 265503 [details]
Patch to find build failures v18; do not review
Comment 27 David Kilzer (:ddkilzer) 2015-11-13 23:06:47 PST
Created attachment 265537 [details]
Patch to find build failures v19; do not review
Comment 28 David Kilzer (:ddkilzer) 2015-11-14 00:26:18 PST
Created attachment 265538 [details]
Patch to find build failures v20; do not review
Comment 29 David Kilzer (:ddkilzer) 2015-11-14 07:07:55 PST
Created attachment 265540 [details]
Patch to find build failures v21; do not review
Comment 30 Darin Adler 2015-11-14 16:52:01 PST
Comment on attachment 265540 [details]
Patch to find build failures v21; do not review

Best way to indicate "do no review" is to not set review? and trigger EWS explicitly instead.
Comment 31 David Kilzer (:ddkilzer) 2015-11-16 10:44:45 PST
Created attachment 265592 [details]
Patch to find build failures v22
Comment 32 David Kilzer (:ddkilzer) 2015-11-16 11:05:26 PST
Created attachment 265595 [details]
Patch to find build failures v23
Comment 33 David Kilzer (:ddkilzer) 2015-11-16 14:38:35 PST
Created attachment 265621 [details]
Patch to find build failures v24
Comment 34 David Kilzer (:ddkilzer) 2015-11-25 00:29:35 PST
Created attachment 266147 [details]
Patch to find build failures v25
Comment 35 David Kilzer (:ddkilzer) 2015-11-25 01:13:45 PST
Created attachment 266148 [details]
Patch to find build failures v26