RESOLVED FIXED 104417
[check-webkit-style] False positive (readability/enum_casing) on CF-styled enum members 
https://bugs.webkit.org/show_bug.cgi?id=104417
Summary [check-webkit-style] False positive (readability/enum_casing) on CF-styled en...
Conrad Shultz
Reported 2012-12-07 16:42:51 PST
As seen for, e.g., the first patch for https://bugs.webkit.org/show_bug.cgi?id=104166, check-webkit-style reports "enum members should use InterCaps with an initial capital letter" for enums in WebKit2 that, apparently correctly, follow the CF-style convention of k-prefixed members. See, e.g., all the enums declared in WKPageLoadTypes.h.
Attachments
Patch v1 (5.66 KB, patch)
2015-11-10 14:12 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2015-11-10 14:12:22 PST
Created attachment 265229 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2015-11-10 14:12:55 PST
I got tired of seeing these errors in Bug 151029. :)
Brent Fulgham
Comment 3 2015-11-10 14:15:59 PST
Comment on attachment 265229 [details] Patch v1 r=me. Thank goodness someone finally fixed this!
WebKit Commit Bot
Comment 4 2015-11-10 15:03:18 PST
Comment on attachment 265229 [details] Patch v1 Clearing flags on attachment: 265229 Committed r192274: <http://trac.webkit.org/changeset/192274>
WebKit Commit Bot
Comment 5 2015-11-10 15:03:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.