Bug 104417 - [check-webkit-style] False positive (readability/enum_casing) on CF-styled enum members
Summary: [check-webkit-style] False positive (readability/enum_casing) on CF-styled en...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Depends on:
Reported: 2012-12-07 16:42 PST by Conrad Shultz
Modified: 2015-11-10 15:03 PST (History)
9 users (show)

See Also:

Patch v1 (5.66 KB, patch)
2015-11-10 14:12 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Shultz 2012-12-07 16:42:51 PST
As seen for, e.g., the first patch for https://bugs.webkit.org/show_bug.cgi?id=104166, check-webkit-style reports "enum members should use InterCaps with an initial capital letter" for enums in WebKit2 that, apparently correctly, follow the CF-style convention of k-prefixed members.

See, e.g., all the enums declared in WKPageLoadTypes.h.
Comment 1 David Kilzer (:ddkilzer) 2015-11-10 14:12:22 PST
Created attachment 265229 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2015-11-10 14:12:55 PST
I got tired of seeing these errors in Bug 151029.  :)
Comment 3 Brent Fulgham 2015-11-10 14:15:59 PST
Comment on attachment 265229 [details]
Patch v1

r=me. Thank goodness someone finally fixed this!
Comment 4 WebKit Commit Bot 2015-11-10 15:03:18 PST
Comment on attachment 265229 [details]
Patch v1

Clearing flags on attachment: 265229

Committed r192274: <http://trac.webkit.org/changeset/192274>
Comment 5 WebKit Commit Bot 2015-11-10 15:03:23 PST
All reviewed patches have been landed.  Closing bug.