Bug 150894 - Web Inspector: WebInspector.Color should support #rgba and #rrggbbaa syntax
Summary: Web Inspector: WebInspector.Color should support #rgba and #rrggbbaa syntax
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
Keywords: InRadar
Depends on:
Reported: 2015-11-04 10:12 PST by Dean Jackson
Modified: 2015-11-04 16:00 PST (History)
8 users (show)

See Also:

[PATCH] Proposed Fix (28.82 KB, patch)
2015-11-04 14:01 PST, Joseph Pecoraro
joepeck: commit-queue-
Details | Formatted Diff | Diff
[PATCH] Proposed Fix (29.59 KB, patch)
2015-11-04 14:16 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2015-11-04 10:12:25 PST
See https://bugs.webkit.org/show_bug.cgi?id=150853

We now support 4 and 8 digit hex colors. I think we'll need to update CodeMirror css.js and our CodeMirrorAdditions.js + CodeMirrorTextMarkers.js + Color.js
Comment 1 Radar WebKit Bug Importer 2015-11-04 10:13:04 PST
Comment 2 Joseph Pecoraro 2015-11-04 14:01:11 PST
Created attachment 264811 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2015-11-04 14:10:48 PST
Comment on attachment 264811 [details]
[PATCH] Proposed Fix

Got another tweak I want to make.
Comment 4 Joseph Pecoraro 2015-11-04 14:16:02 PST
Created attachment 264813 [details]
[PATCH] Proposed Fix
Comment 5 Joseph Pecoraro 2015-11-04 14:31:21 PST
CodeMirror issue:
Comment 6 WebKit Commit Bot 2015-11-04 16:00:42 PST
Comment on attachment 264813 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 264813

Committed r192040: <http://trac.webkit.org/changeset/192040>
Comment 7 WebKit Commit Bot 2015-11-04 16:00:47 PST
All reviewed patches have been landed.  Closing bug.