Bug 150853 - Accept 8 and 4 value hex colors (#RRGGBBAA)
Summary: Accept 8 and 4 value hex colors (#RRGGBBAA)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar, WebExposed
: 39140 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-11-03 13:28 PST by Dean Jackson
Modified: 2016-08-03 13:23 PDT (History)
7 users (show)

See Also:

Attachments
Patch (14.17 KB, patch)
2015-11-03 13:52 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-mavericks (775.98 KB, application/zip)
2015-11-03 14:36 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (858.82 KB, application/zip)
2015-11-03 14:39 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews112 for mac-yosemite (902.95 KB, application/zip)
2015-11-03 14:49 PST, Build Bot 		no flags Details
Patch (29.20 KB, patch)
2015-11-03 16:22 PST, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2015-11-03 13:28:15 PST 
Accept 8 and 4 value hex colors (#RRGGBBAA)
Comment 1 Radar WebKit Bug Importer 2015-11-03 13:29:18 PST 
<rdar://problem/23380930>
Comment 2 Dean Jackson 2015-11-03 13:52:38 PST 
Created attachment 264720 [details]
Patch
Comment 3 Build Bot 2015-11-03 14:36:20 PST 
Comment on attachment 264720 [details]
Patch

Attachment 264720 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/378494

New failing tests:
imported/w3c/canvas/2d.fillStyle.parse.invalid.hex8.html
imported/w3c/canvas/2d.fillStyle.parse.invalid.hex4.html
fast/dom/attribute-legacy-colors.html
svg/dom/rgb-color-parser.html
canvas/philip/tests/2d.fillStyle.parse.invalid.hex4.html
imported/w3c/css/css-color-3/t421-rgb-hex-parsing-f.xht
canvas/philip/tests/2d.fillStyle.parse.invalid.hex8.html
Comment 4 Build Bot 2015-11-03 14:36:22 PST 
Created attachment 264727 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 Build Bot 2015-11-03 14:39:55 PST 
Comment on attachment 264720 [details]
Patch

Attachment 264720 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/378495

New failing tests:
imported/w3c/canvas/2d.fillStyle.parse.invalid.hex8.html
imported/w3c/canvas/2d.fillStyle.parse.invalid.hex4.html
fast/dom/attribute-legacy-colors.html
svg/dom/rgb-color-parser.html
canvas/philip/tests/2d.fillStyle.parse.invalid.hex4.html
imported/w3c/css/css-color-3/t421-rgb-hex-parsing-f.xht
canvas/philip/tests/2d.fillStyle.parse.invalid.hex8.html
Comment 6 Build Bot 2015-11-03 14:39:58 PST 
Created attachment 264729 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 7 Build Bot 2015-11-03 14:49:02 PST 
Comment on attachment 264720 [details]
Patch

Attachment 264720 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/378520

New failing tests:
imported/w3c/canvas/2d.fillStyle.parse.invalid.hex8.html
imported/w3c/canvas/2d.fillStyle.parse.invalid.hex4.html
fast/dom/attribute-legacy-colors.html
svg/dom/rgb-color-parser.html
canvas/philip/tests/2d.fillStyle.parse.invalid.hex4.html
imported/w3c/css/css-color-3/t421-rgb-hex-parsing-f.xht
canvas/philip/tests/2d.fillStyle.parse.invalid.hex8.html
Comment 8 Build Bot 2015-11-03 14:49:05 PST 
Created attachment 264732 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Dean Jackson 2015-11-03 16:22:31 PST 
Created attachment 264751 [details]
Patch
Comment 10 Dean Jackson 2015-11-04 09:51:01 PST 
Committed r192023: <http://trac.webkit.org/changeset/192023>
Comment 11 Zoë Bijl 2016-05-26 17:55:55 PDT 
Thanks for fixing this!
Comment 12 Dean Jackson 2016-08-03 13:23:42 PDT 
*** Bug 39140 has been marked as a duplicate of this bug. ***