Bug 150839 - Modern IDB: Land empty IDBCursor/Index IDL implementations
Summary: Modern IDB: Land empty IDBCursor/Index IDL implementations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117
  Show dependency treegraph
 
Reported: 2015-11-03 09:11 PST by Brady Eidson
Modified: 2015-11-03 14:25 PST (History)
2 users (show)

See Also:


Attachments
Patch v1 (38.04 KB, patch)
2015-11-03 09:36 PST, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch v2 (37.85 KB, patch)
2015-11-03 12:08 PST, Brady Eidson
achristensen: review-
achristensen: commit-queue-
Details | Formatted Diff | Diff
Patch v3 (37.88 KB, patch)
2015-11-03 13:34 PST, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-11-03 09:11:32 PST
Modern IDB: Land IDBCursor/Index IDL implementations

They'll basically be no-ops at this point, but just get a lot of template/boilerplate code out of the way, as well as project file changes.
Comment 1 Brady Eidson 2015-11-03 09:36:33 PST
Created attachment 264695 [details]
Patch v1
Comment 2 Brady Eidson 2015-11-03 12:08:03 PST
Created attachment 264707 [details]
Patch v2
Comment 3 WebKit Commit Bot 2015-11-03 12:11:00 PST
Attachment 264707 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/client/IDBCursorWithValueImpl.h:26:  #ifndef header guard has wrong style, please use: IDBCursorWithValueImpl_h  [build/header_guard] [5]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Alex Christensen 2015-11-03 12:34:15 PST
Comment on attachment 264707 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=264707&action=review

Looks mostly good.  I'll take a glance at the next patch

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

remove

> Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.h:42
> +    virtual const Deprecated::ScriptValue& key() const override final;

new code with deprecated?

> Source/WebCore/Modules/indexeddb/shared/IDBIndexInfo.cpp:33
> +namespace WebCore {
> +
> +} // namespace WebCore

This file looks pretty exciting so far.

> Source/WebCore/Modules/indexeddb/shared/IDBIndexInfo.h:44
> +private:
> +    IDBIndexInfo();

how do you make one of these?
Comment 5 Brady Eidson 2015-11-03 13:33:36 PST
(In reply to comment #4)
> Comment on attachment 264707 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=264707&action=review
> 
> Looks mostly good.  I'll take a glance at the next patch
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests (OOPS!).
> 
> remove

Whoops.

> 
> > Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.h:42
> > +    virtual const Deprecated::ScriptValue& key() const override final;
> 
> new code with deprecated?
> 

New code implementing old interface. After LegacyIDB is nuked would be a good time to do a sweep of all of that (including the JS bindings, unfortunately)

https://bugs.webkit.org/show_bug.cgi?id=150854 for that

> > Source/WebCore/Modules/indexeddb/shared/IDBIndexInfo.cpp:33
> > +namespace WebCore {
> > +
> > +} // namespace WebCore
> 
> This file looks pretty exciting so far.

It is not!

> 
> > Source/WebCore/Modules/indexeddb/shared/IDBIndexInfo.h:44
> > +private:
> > +    IDBIndexInfo();
> 
> how do you make one of these?

In this patch, you do not!
Comment 6 Brady Eidson 2015-11-03 13:34:11 PST
Created attachment 264719 [details]
Patch v3
Comment 7 WebKit Commit Bot 2015-11-03 14:25:07 PST
Comment on attachment 264719 [details]
Patch v3

Clearing flags on attachment: 264719

Committed r191980: <http://trac.webkit.org/changeset/191980>
Comment 8 WebKit Commit Bot 2015-11-03 14:25:12 PST
All reviewed patches have been landed.  Closing bug.