Bug 150755 – Make CMake builder build with CMake

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: New Bugs

[Alex Christensen]

Make CMake builder build with CMake

[Alex Christensen]

Created attachment 264471 [details]
Patch

[WebKit Commit Bot]

Attachment 264471 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/config.json:0:  No JSON object could be decoded  [json/syntax] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

This makes https://bugs.webkit.org/show_bug.cgi?id=150738 do the right thing.  The build master will need to be restarted after landing this change.  I'm not sure how to make this show up on the buildbot dashboard

[Alex Christensen]

Created attachment 264473 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 264473 [details]
Patch

LGTM, but please add the missing unittest too before landing.

[Alexey Proskuryakov]

Comment on attachment 264473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264473&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:843
> +class BuildWithCMakeFactory(Factory):

I'm not a big fan of adding factories. This creates a combinatorial explosion, as you'll need a separate factory to build with ASan, and for every other existing variant.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:40
> +        "Apple El Capitan CMake Debug (Build)": {platform: Dashboard.Platform.MacOSXElCapitan, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit, heading: "CMake"},

This presumably made it appear. 

The question I have, did we agree to keep it green? I have not seen any discussions to that effect. I'd hate to roll out patches for breaking Mac CMake build if we don't get any benefits from it.

[Alex Christensen]

Alexey, could you commit this and restart the master?
(In reply to comment #6)
> Comment on attachment 264473 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=264473&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:843
> > +class BuildWithCMakeFactory(Factory):
> 
> I'm not a big fan of adding factories. This creates a combinatorial
> explosion, as you'll need a separate factory to build with ASan, and for
> every other existing variant.
I see your point, but right now there is just one builder.  I think we can reorganize things when this becomes a problem.
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:40
> > +        "Apple El Capitan CMake Debug (Build)": {platform: Dashboard.Platform.MacOSXElCapitan, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit, heading: "CMake"},
> 
> This presumably made it appear. 
I didn't test this.  I assume this is all that's needed.
> 
> The question I have, did we agree to keep it green? I have not seen any
> discussions to that effect. I'd hate to roll out patches for breaking Mac
> CMake build if we don't get any benefits from it.
It's probably not critical enough to roll out patches that break it right now, and we don't get benefits from it right now, but we will soon.  Right now I'm the only one to see build failures after building on my own computer.  I want it to be easier to not lose progress on this work.

[Lucas Forschler]

Comment on attachment 264473 [details]
Patch

I have this working already, by using the 'additionalArguments'  parameter in config.json.
I'm not sure why we need a second factory?

[Alexey Proskuryakov]

> It's probably not critical enough to roll out patches that break it right now

In this case, it's probably better to not add it to the dashboard for now.

[Alex Christensen]

(In reply to comment #8)
> Comment on attachment 264473 [details]
> Patch
> 
> I have this working already, by using the 'additionalArguments'  parameter
> in config.json.
> I'm not sure why we need a second factory?
This is just the way I thought of.  http://trac.webkit.org/changeset/191843 solves this problem.