Bug 150738 - Add buildbot configuration for CMake
Summary: Add buildbot configuration for CMake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas Forschler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-30 15:37 PDT by Lucas Forschler
Modified: 2015-11-03 07:34 PST (History)
6 users (show)

See Also:


Attachments
v1 patch to add builder and scheduler for the cmake magic. (3.35 KB, patch)
2015-10-30 15:43 PDT, Lucas Forschler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2015-10-30 15:37:28 PDT
make cmake make :)
Comment 1 Lucas Forschler 2015-10-30 15:43:16 PDT
Created attachment 264431 [details]
v1 patch to add builder and scheduler for the cmake magic.

v1 patch to add builder and scheduler.
Comment 2 WebKit Commit Bot 2015-10-30 16:36:15 PDT
Comment on attachment 264431 [details]
v1 patch to add builder and scheduler for the cmake magic.

Clearing flags on attachment: 264431

Committed r191827: <http://trac.webkit.org/changeset/191827>
Comment 3 WebKit Commit Bot 2015-10-30 16:36:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Alexey Proskuryakov 2015-10-30 20:24:06 PDT
Do we want this on the bot watcher's dashboard?
Comment 5 Alex Christensen 2015-10-31 01:16:55 PDT
(In reply to comment #4)
> Do we want this on the bot watcher's dashboard?
Probably.  Also, this didn't make it actually use --cmake to build.  Followup in https://bugs.webkit.org/show_bug.cgi?id=150755
Comment 6 Csaba Osztrogonác 2015-10-31 04:39:21 PDT
(In reply to comment #2)
> Comment on attachment 264431 [details]
> v1 patch to add builder and scheduler for the cmake magic.
> 
> Clearing flags on attachment: 264431
> 
> Committed r191827: <http://trac.webkit.org/changeset/191827>

Please fix the master.cfg unittest:

FAIL: test_builder Apple El Capitan CMake Debug (Build) (__main__.BuildStepsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./mastercfg_unittest.py", line 447, in doTest
    self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps))
AssertionError: Missing expected result for builder: Apple El Capitan CMake Debug (Build)
 Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit']
Comment 7 Csaba Osztrogonác 2015-11-03 07:34:11 PST
Unittest added in http://trac.webkit.org/changeset/191951.