make cmake make :)
Created attachment 264431 [details] v1 patch to add builder and scheduler for the cmake magic. v1 patch to add builder and scheduler.
Comment on attachment 264431 [details] v1 patch to add builder and scheduler for the cmake magic. Clearing flags on attachment: 264431 Committed r191827: <http://trac.webkit.org/changeset/191827>
All reviewed patches have been landed. Closing bug.
Do we want this on the bot watcher's dashboard?
(In reply to comment #4) > Do we want this on the bot watcher's dashboard? Probably. Also, this didn't make it actually use --cmake to build. Followup in https://bugs.webkit.org/show_bug.cgi?id=150755
(In reply to comment #2) > Comment on attachment 264431 [details] > v1 patch to add builder and scheduler for the cmake magic. > > Clearing flags on attachment: 264431 > > Committed r191827: <http://trac.webkit.org/changeset/191827> Please fix the master.cfg unittest: FAIL: test_builder Apple El Capitan CMake Debug (Build) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./mastercfg_unittest.py", line 447, in doTest self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps)) AssertionError: Missing expected result for builder: Apple El Capitan CMake Debug (Build) Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit']
Unittest added in http://trac.webkit.org/changeset/191951.