RESOLVED FIXED 150613
Rename JSDOMWrapper.impl to JSDOMWrapper.wrapped 
https://bugs.webkit.org/show_bug.cgi?id=150613
Summary Rename JSDOMWrapper.impl to JSDOMWrapper.wrapped
youenn fablet
Reported 2015-10-27 17:08:37 PDT
Following on JSDOMWrapper renaming, we may want to rename impl() and m_impl to wrapped()/m_wrapped, in JSDOMWrapper and related classes.
Attachments
Patch (404.03 KB, patch)
2015-10-27 17:15 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Updating mm files (409.74 KB, patch)
2015-10-27 17:24 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Updating mm files (410.30 KB, patch)
2015-10-27 17:41 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fixing win (413.01 KB, patch)
2015-10-28 23:21 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fixing IDB (413.40 KB, patch)
2015-10-28 23:52 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (413.85 KB, patch)
2015-11-02 01:38 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fixing IDBObjectStore (415.48 KB, patch)
2015-11-02 02:15 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fixing IDBObjectStore (415.48 KB, patch)
2015-11-02 02:54 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2015-10-27 17:15:26 PDT
Created attachment 264177 [details] Patch
youenn fablet
Comment 2 2015-10-27 17:16:33 PDT
This is a follow-up of bug 150120
youenn fablet
Comment 3 2015-10-27 17:24:55 PDT
Created attachment 264181 [details] Updating mm files
youenn fablet
Comment 4 2015-10-27 17:41:23 PDT
Created attachment 264184 [details] Updating mm files
youenn fablet
Comment 5 2015-10-28 23:21:31 PDT
Created attachment 264304 [details] Fixing win
youenn fablet
Comment 6 2015-10-28 23:52:35 PDT
Created attachment 264305 [details] Fixing IDB
youenn fablet
Comment 7 2015-11-02 01:38:14 PST
Created attachment 264567 [details] Patch for landing
youenn fablet
Comment 8 2015-11-02 02:15:48 PST
Created attachment 264571 [details] Fixing IDBObjectStore
WebKit Commit Bot
Comment 9 2015-11-02 02:50:59 PST
Comment on attachment 264571 [details] Fixing IDBObjectStore Rejecting attachment 264571 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -c /Volumes/Data/EWS/WebKit/Source/WebCore/bindings/js/JSImageConstructor.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/JSImageConstructor.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/JSIDBObjectStoreCustom.o bindings/js/JSIDBObjectStoreCustom.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/371271
youenn fablet
Comment 10 2015-11-02 02:54:04 PST
Created attachment 264572 [details] Fixing IDBObjectStore
WebKit Commit Bot
Comment 11 2015-11-02 03:45:12 PST
Comment on attachment 264572 [details] Fixing IDBObjectStore Clearing flags on attachment: 264572 Committed r191887: <http://trac.webkit.org/changeset/191887>
WebKit Commit Bot
Comment 12 2015-11-02 03:45:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.