Bug 150120 - Rename JSDOMWrapper to JSDOMObject and JSDOMWrapperWithImplementation to JSDOMWrapper
Summary: Rename JSDOMWrapper to JSDOMObject and JSDOMWrapperWithImplementation to JSDO...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-14 05:11 PDT by youenn fablet
Modified: 2015-10-14 12:19 PDT (History)
3 users (show)

See Also:

Attachments
Patch (57.31 KB, patch)
2015-10-14 09:17 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2015-10-14 05:11:24 PDT 
Following on https://bugs.webkit.org/show_bug.cgi?id=149660, we might want to rename JSDOMWrapper to JSDOMObject and JSDOMWrapperWithImplementation to JSDOMWrapper
Comment 1 youenn fablet 2015-10-14 09:17:39 PDT 
Created attachment 263080 [details]
Patch
Comment 2 youenn fablet 2015-10-14 09:23:01 PDT 
Comment on attachment 263080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263080&action=review

> Source/WebCore/bindings/js/JSDOMBinding.h:239
> +template<typename WrapperClass, typename DOMClass> inline JSDOMObject* createWrapper(JSDOMGlobalObject* globalObject, DOMClass* node)

We might want in the future to move from JSDOMObject to JSDOMWrapper<T>, make ScriptWrappable a template and so on.
Comment 3 WebKit Commit Bot 2015-10-14 12:19:12 PDT 
Comment on attachment 263080 [details]
Patch

Clearing flags on attachment: 263080

Committed r191060: <http://trac.webkit.org/changeset/191060>
Comment 4 WebKit Commit Bot 2015-10-14 12:19:17 PDT 
All reviewed patches have been landed.  Closing bug.