Bug 150608 – Web Inspector: "No Filter Results" message overlaps Debugger sidebar sections

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Created attachment 264164 [details]
[Image] Overlapping message

* SUMMARY
No Filter Results message overlaps Debugger sidebar sections. The message element should remain within Scripts details section.

* STEPS TO REPRODUCE
1. Inspector -> Debugger tab
2. Force the page to pause in the debugger
3. Enter nonsense filter text so all scripts are filtered
  => Message overlaps other sidebar sections other than Scripts (Call Stack, Pause Reason)

[Radar WebKit Bug Importer]

<rdar://problem/23284314>

[Matt Baker]

This will require additional logic to handle the three cases involving a filtered tree outline in the navigation sidebar:

1) The tree is a child of the panel's content element. In this case the message needs to be a child of the content area, i.e. the current way we do things.

2) The tree is a descendent of a details section, and other details sections are visible (e.g. Debugger sidebar when paused). In this case the message needs to be a child of the details section to which the tree belongs.

3) The tree is a descendent of a details section, and other details sections are hidden (e.g. Debugger sidebar when not paused). The message should be handled as in case 1.

[Matt Baker]

*** Bug 152350 has been marked as a duplicate of this bug. ***

[Joseph Pecoraro]

This prevents clicking in the sidebar and it is not obvious why the clicks are not working. This is important to fix.

[Timothy Hatcher]

We also might want to add pointer-events: none to these elements to avoid bugs like this. Even though it would still overlap, clicks would work. That way accidental overlaps are not catastrophic.

[Matt Baker]

Created attachment 267668 [details]
[Screenshot] Smarter filter message placement

Filter message containers are now placed at the correct level in the DOM.

[Matt Baker]

Created attachment 267675 [details]
[Patch] Proposed Fix

[Blaze Burg]

Comment on attachment 267675 [details]
[Patch] Proposed Fix

Great work. I couldn't find any regressions in my testing with the patch applied. Let's try it out when you are ready.

[WebKit Commit Bot]

Comment on attachment 267675 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 267675

Committed r194460: <http://trac.webkit.org/changeset/194460>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.