Bug 150322 - Fix the !ENABLE(CSS_GRID_LAYOUT) build after r190840
Summary: Fix the !ENABLE(CSS_GRID_LAYOUT) build after r190840
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 149698
  Show dependency tree / graph
 
Reported: 2015-10-19 03:50 PDT by Csaba Osztrogonác
Modified: 2015-10-19 09:10 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.07 KB, patch)
2015-10-19 03:52 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-10-19 03:50:12 PDT 
https://trac.webkit.org/changeset/190840 broke the !ENABLE(CSS_GRID_LAYOUT) build:

../../Source/WebCore/html/HTMLDetailsElement.cpp: In function 'const WTF::AtomicString& WebCore::summarySlotName()':
../../Source/WebCore/html/HTMLDetailsElement.cpp:43:52: error: variable 'WTF::NeverDestroyed<WTF::AtomicString> summarySlot' has initializer but incomplete type
../../Source/WebCore/html/HTMLDetailsElement.cpp:45:1: error: control reaches end of non-void function [-Werror=return-type]
cc1plus: all warnings being treated as errors

If ENABLE(CSS_GRID_LAYOUT) is true, NeverDestroyed.h is included by one of the header files,
that's why we didn't notice this error previously. We shouldn't depend on this include,
let's include NeverDestroyed.h explicitly, because this cpp needs it.
Comment 1 Csaba Osztrogonác 2015-10-19 03:52:26 PDT 
Created attachment 263466 [details]
Patch
Comment 2 WebKit Commit Bot 2015-10-19 09:10:55 PDT 
Comment on attachment 263466 [details]
Patch

Clearing flags on attachment: 263466

Committed r191289: <http://trac.webkit.org/changeset/191289>
Comment 3 WebKit Commit Bot 2015-10-19 09:10:59 PDT 
All reviewed patches have been landed.  Closing bug.