Bug 150275 – Rename the PICTURE_SIZES flag to CURRENTSRC

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yoav Weiss]

Rename the PICTURE_SIZES flag to CURRENTSRC

[Yoav Weiss]

Created attachment 263369 [details]
Patch

[WebKit Commit Bot]

Attachment 263369 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yoav Weiss]

Created attachment 263370 [details]
Patch

[Yoav Weiss]

As a split from https://bugs.webkit.org/show_bug.cgi?id=150230 this patch renames the PICTURE_SIZES flag into CURRENTSRC (which is the attribute that this flag is used for now).

[Yoav Weiss]

Created attachment 263454 [details]
Patch

[Dean Jackson]

Comment on attachment 263454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263454&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:156
> -ENABLE_PICTURE_SIZES = ;
> +ENABLE_CURRENTSRC = ;

These files are slightly sorted. You should probably move CURRENTSRC to earlier in the list.

> Source/cmake/WebKitFeatures.cmake:134
> -    WEBKIT_OPTION_DEFINE(ENABLE_PICTURE_SIZES "Toggle sizes attribute support" PRIVATE OFF)
> +    WEBKIT_OPTION_DEFINE(ENABLE_CURRENTSRC "Toggle currentSrc attribute support" PRIVATE OFF)

Same here.

[Yoav Weiss]

Created attachment 263557 [details]
Patch

[Yoav Weiss]

Created attachment 263559 [details]
Patch

[Yoav Weiss]

Thanks for reviewing! :) Re-sorted these files and some others.

[WebKit Commit Bot]

Comment on attachment 263559 [details]
Patch

Clearing flags on attachment: 263559

Committed r191334: <http://trac.webkit.org/changeset/191334>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.