Bug 150230 – Expose HTMLImageElement sizes attribute in IDL

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yoav Weiss]

Fix idl error related to the sizes attribute

[Yoav Weiss]

Created attachment 263258 [details]
Patch

[Yoav Weiss]

This change makes sure that sizes support can be properly detected, to avoid polyfills from trying to "polyfill" sizes support when sizes is natively supported.

[Build Bot]

Comment on attachment 263258 [details]
Patch

Attachment 263258 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/295232

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html

[Build Bot]

Created attachment 263261 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 263258 [details]
Patch

Attachment 263258 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/295239

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html

[Build Bot]

Created attachment 263262 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Yoav Weiss]

Created attachment 263264 [details]
Patch

[Yoav Weiss]

Created attachment 263265 [details]
Patch

[Chris Dumez]

Comment on attachment 263265 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263265&action=review

> Source/WebCore/html/HTMLImageElement.idl:-35
> -#if ENABLE_PICTURE_SIZES

If I look at FeatureList.pm, I see:
"""
{ option => "picture-sizes", desc => "Toggle sizes attribute support",
      define => "ENABLE_PICTURE_SIZES", default => 1, value => \$pictureSizesSupport },
"""

Therefore, it looks it is intended for the 'sizes' attributes to be behind the ENABLE_PICTURE_SIZES compile-time flag. Do we really want to expose HTMLImageElement.sizes to the Web for all ports?

[Chris Dumez]

Also, the bug title is not very clear about the behavior change. This patch essentially causes the Mac port (at least) to start exposing HTMLImageElement.sizes by default to the Web. It may be worth starting a discussion on webkit-dev about this.

[Benjamin Poulain]

Comment on attachment 263265 [details]
Patch

R- because of the misleading title.

[Benjamin Poulain]

You need to poke Dean to get the authorization for this.
IIRC, he disabled the attribute because compatibility with some stupid libraries.

[Yoav Weiss]

The `sizes` attribute wasn't supposed to be a part of Dean's patch that removed support for currentSrc, due to a bug in old picturefill libraries. The removal of this attribute from idl as part of that patch was an error, which this patch is fixing.

I'll fix up the title to reflect that.

Also, I think I'll change the flag's name since it's not really doing what its name says it does.

[Yoav Weiss]

Created attachment 263351 [details]
Patch

[Yoav Weiss]

Created attachment 263352 [details]
Patch

[Yoav Weiss]

Created attachment 263576 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 263576 [details]
Patch

Clearing flags on attachment: 263576

Committed r192098: <http://trac.webkit.org/changeset/192098>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.