Bug 150190 - Always enable MASM_PROBE for debug builds.
Summary: Always enable MASM_PROBE for debug builds.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-15 14:58 PDT by Mark Lam
Modified: 2015-10-17 17:28 PDT (History)
10 users (show)

See Also:

Attachments
the patch. (1.09 KB, patch)
2015-10-15 15:00 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-10-15 14:58:54 PDT 
Enabling it only costs some code space, and incurs no performance cost until put to use.  Enabling it for debug builds saves us from having to rebuild the world in order to enable it for debugging.
Comment 1 Mark Lam 2015-10-15 15:00:51 PDT 
Created attachment 263193 [details]
the patch.
Comment 2 Geoffrey Garen 2015-10-15 16:06:42 PDT 
Comment on attachment 263193 [details]
the patch.

Please resolve the namespacing for MASM_PROBE #defines in headers before landing. All macros should have a prefix -- and it looks like you've chosen "PROBE_".
Comment 3 Mark Lam 2015-10-16 12:15:24 PDT 
Per our discussion yesterday, the namespacing of MASM_PROBE #defines will not be an issue if they are only local to a .cpp file.

In https://bugs.webkit.org/show_bug.cgi?id=150239, I've moved all the of probe implementations from the JITStubs<CPU>.h files to their corresponding MacroAssembler<CPU>.cpp files.

Hence, this patch is good for landing now.  Thanks.
Comment 4 WebKit Commit Bot 2015-10-16 13:02:59 PDT 
Comment on attachment 263193 [details]
the patch.

Clearing flags on attachment: 263193

Committed r191197: <http://trac.webkit.org/changeset/191197>
Comment 5 WebKit Commit Bot 2015-10-16 13:03:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Mark Lam 2015-10-17 17:28:02 PDT 
Follow up landed in r191254: <http://trac.webkit.org/r191254>.  This adds CPU(X86) (which was accidentally left out) to the supported list of MASM_PROBE CPUs.