Bug 150239 - Move all the probe trampolines into their respective MacroAssembler files.
Summary: Move all the probe trampolines into their respective MacroAssembler files.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-16 10:41 PDT by Mark Lam
Modified: 2015-10-16 12:12 PDT (History)
1 user (show)

See Also:

Attachments
the patch. (224.31 KB, patch)
2015-10-16 11:32 PDT, Mark Lam 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-10-16 10:41:01 PDT 
With this, we can get rid of all the JITStubs<CPU>.cpp files.  There is one exception: JITStubsMSVC64.asm.  That one is unrelated to the probe mechanism.  So, I'll leave it as is.
Comment 1 Mark Lam 2015-10-16 11:32:50 PDT 
Created attachment 263299 [details]
the patch.
Comment 2 WebKit Commit Bot 2015-10-16 11:34:55 PDT 
Attachment 263299 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp:309:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp:491:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/assembler/MacroAssemblerARM64.cpp:454:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/assembler/MacroAssemblerARMv7.cpp:321:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/assembler/MacroAssemblerARM.cpp:348:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 5 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Saam Barati 2015-10-16 12:02:16 PDT 
Comment on attachment 263299 [details]
the patch.

LGTM
Comment 4 Mark Lam 2015-10-16 12:12:27 PDT 
Thanks.  Landed in r191191: <http://trac.webkit.org/r191191>.