Bug 150163 - Binding generator should generate names for JSBuiltins partial interface methods using ImplementedBy value
Summary: Binding generator should generate names for JSBuiltins partial interface meth...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks: 149499
  Show dependency tree / graph
 
Reported: 2015-10-15 05:41 PDT by youenn fablet
Modified: 2015-10-19 03:45 PDT (History)
3 users (show)

See Also:

Attachments
Patch (11.46 KB, patch)
2015-10-15 05:50 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (11.51 KB, patch)
2015-10-19 02:50 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2015-10-15 05:41:18 PDT 
To allow JS builtin implementation splitting as done using partial interfaces for WebIDL, the names of the functions used to create the JS builtin functions should be updated.
Comment 1 youenn fablet 2015-10-15 05:50:43 PDT 
Created attachment 263146 [details]
Patch
Comment 2 youenn fablet 2015-10-15 05:51:31 PDT 
Split of bug 149994
Comment 3 youenn fablet 2015-10-15 06:10:28 PDT 
(In reply to comment #2)
> Split of bug 149994

bug 149499 in fact
Comment 4 Darin Adler 2015-10-18 16:28:41 PDT 
Comment on attachment 263146 [details]
Patch

OK. It’s a little bit sloppy for us to use the smushed together “builtin” as it if’s a word. The phrase is “built in” or possible “built-in”.
Comment 5 youenn fablet 2015-10-19 02:50:51 PDT 
Created attachment 263462 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2015-10-19 03:45:42 PDT 
Comment on attachment 263462 [details]
Patch for landing

Clearing flags on attachment: 263462

Committed r191288: <http://trac.webkit.org/changeset/191288>
Comment 7 WebKit Commit Bot 2015-10-19 03:45:48 PDT 
All reviewed patches have been landed.  Closing bug.