Bug 149994 - Perf dashboard tools shouldn't require server credentials in multiple configuration files
Summary: Perf dashboard tools shouldn't require server credentials in multiple configu...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Depends on:
Reported: 2015-10-09 20:26 PDT by Ryosuke Niwa
Modified: 2016-02-16 13:52 PST (History)
7 users (show)

See Also:

Patch (11.90 KB, patch)
2015-10-09 21:26 PDT, Ryosuke Niwa
cdumez: review+
cdumez: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-10-09 20:26:54 PDT
Right now, change detection script's configurations, subversion configurations,
and the dashboard access configurations each require username/password.

Consolidate all those into one JSON at most.
Comment 1 Ryosuke Niwa 2015-10-09 21:26:17 PDT
Created attachment 262817 [details]
Comment 2 Chris Dumez 2015-10-12 15:41:29 PDT
Comment on attachment 262817 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=262817&action=review

r=me with comments.

> Websites/perf.webkit.org/ChangeLog:3
> +        Perf dashboard tools shouldn't require sever credentials in multiple configuration files


> Websites/perf.webkit.org/tools/detect-changes.js:31
> +    for (var i = 0; i < args.length; i+=2) {

missing spaces around +=

> Websites/perf.webkit.org/tools/detect-changes.js:42
> +            console.error('Invalid arguemnt:', current);

typo: argument.
Comment 3 Ryosuke Niwa 2015-10-12 16:06:14 PDT
Committed r190900: <http://trac.webkit.org/changeset/190900>