Bug 150113 – CSSKeyframesRule::appendRule is deprecated, but is actually the spec

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Ricci Adams]

At the time of this writing, CSS Animations Level 1 has an appendRule() method.  This use to be insertRule() (see https://bugs.webkit.org/show_bug.cgi?id=57910).

However, a deprecation warning was added for appendRule(), not for insertRule().  https://bugs.webkit.org/show_bug.cgi?id=137532

I believe the deprecation was added to the wrong method.  It should be for insertRule().  Right now, I'm getting deprecation warnings when using the standard appendRule().

[Radar WebKit Bug Importer]

<rdar://problem/23108185>

[Dean Jackson]

Created attachment 263178 [details]
Patch

[Build Bot]

Comment on attachment 263178 [details]
Patch

Attachment 263178 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/292324

New failing tests:
http/tests/css/shared-stylesheet-mutation.html
http/tests/css/shared-stylesheet-mutation-preconstruct.html

[Build Bot]

Created attachment 263181 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 263178 [details]
Patch

Attachment 263178 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/292341

New failing tests:
http/tests/css/shared-stylesheet-mutation.html
http/tests/css/shared-stylesheet-mutation-preconstruct.html

[Build Bot]

Created attachment 263182 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Dean Jackson]

Committed r191132: <http://trac.webkit.org/changeset/191132>