Bug 150113 - CSSKeyframesRule::appendRule is deprecated, but is actually the spec
Summary: CSSKeyframesRule::appendRule is deprecated, but is actually the spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-10-13 19:28 PDT by Ricci Adams
Modified: 2015-10-15 12:59 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.03 KB, patch)
2015-10-15 12:17 PDT, Dean Jackson
simon.fraser: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (782.78 KB, application/zip)
2015-10-15 12:47 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews100 for mac-mavericks (636.67 KB, application/zip)
2015-10-15 12:50 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ricci Adams 2015-10-13 19:28:59 PDT
At the time of this writing, CSS Animations Level 1 has an appendRule() method.  This use to be insertRule() (see https://bugs.webkit.org/show_bug.cgi?id=57910).

However, a deprecation warning was added for appendRule(), not for insertRule().  https://bugs.webkit.org/show_bug.cgi?id=137532

I believe the deprecation was added to the wrong method.  It should be for insertRule().  Right now, I'm getting deprecation warnings when using the standard appendRule().
Comment 1 Radar WebKit Bug Importer 2015-10-14 08:09:22 PDT
<rdar://problem/23108185>
Comment 2 Dean Jackson 2015-10-15 12:17:25 PDT
Created attachment 263178 [details]
Patch
Comment 3 Build Bot 2015-10-15 12:47:25 PDT
Comment on attachment 263178 [details]
Patch

Attachment 263178 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/292324

New failing tests:
http/tests/css/shared-stylesheet-mutation.html
http/tests/css/shared-stylesheet-mutation-preconstruct.html
Comment 4 Build Bot 2015-10-15 12:47:28 PDT
Created attachment 263181 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 5 Build Bot 2015-10-15 12:50:00 PDT
Comment on attachment 263178 [details]
Patch

Attachment 263178 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/292341

New failing tests:
http/tests/css/shared-stylesheet-mutation.html
http/tests/css/shared-stylesheet-mutation-preconstruct.html
Comment 6 Build Bot 2015-10-15 12:50:03 PDT
Created attachment 263182 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 7 Dean Jackson 2015-10-15 12:59:02 PDT
Committed r191132: <http://trac.webkit.org/changeset/191132>