Bug 149872 - Binding generated JS constructors should use GlobalObject references
Summary: Binding generated JS constructors should use GlobalObject references
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-07 00:38 PDT by youenn fablet
Modified: 2015-10-08 00:30 PDT (History)
3 users (show)

See Also:

Attachments
Patch (161.27 KB, patch)
2015-10-07 02:07 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (147.50 KB, patch)
2015-10-07 02:35 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2015-10-07 00:38:27 PDT 
Following on bug 149838, generated JS constructors should manipulate GlobalObject references.
Comment 1 youenn fablet 2015-10-07 02:07:31 PDT 
Created attachment 262589 [details]
Patch
Comment 2 youenn fablet 2015-10-07 02:35:43 PDT 
Created attachment 262590 [details]
Patch
Comment 3 WebKit Commit Bot 2015-10-07 02:38:16 PDT 
Attachment 262590 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMConstructor.h:45:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 53 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2015-10-08 00:30:56 PDT 
Comment on attachment 262590 [details]
Patch

Clearing flags on attachment: 262590

Committed r190714: <http://trac.webkit.org/changeset/190714>
Comment 5 WebKit Commit Bot 2015-10-08 00:30:59 PDT 
All reviewed patches have been landed.  Closing bug.