Bug 149838 - Binding generator XXConstructor::finishCreation should take references as parameters
Summary: Binding generator XXConstructor::finishCreation should take references as par...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on: 149849
Blocks:
  Show dependency tree / graph
 
Reported: 2015-10-06 05:08 PDT by youenn fablet
Modified: 2015-10-06 13:14 PDT (History)
3 users (show)

See Also:

Attachments
Patch (43.26 KB, patch)
2015-10-06 05:22 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Resetting binding tests (53.86 KB, patch)
2015-10-06 12:08 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Fixing OOPS (53.86 KB, patch)
2015-10-06 12:18 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2015-10-06 05:08:05 PDT 
It might be better to move from pointers to references in the code generated by the binding generator.
This may also help aligning generated code with templates that might simplify the binding generator.
Comment 1 youenn fablet 2015-10-06 05:22:33 PDT 
Created attachment 262510 [details]
Patch
Comment 2 WebKit Commit Bot 2015-10-06 09:38:02 PDT 
Comment on attachment 262510 [details]
Patch

Clearing flags on attachment: 262510

Committed r190619: <http://trac.webkit.org/changeset/190619>
Comment 3 WebKit Commit Bot 2015-10-06 09:38:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Commit Bot 2015-10-06 10:29:52 PDT 
Re-opened since this is blocked by bug 149849
Comment 5 youenn fablet 2015-10-06 12:08:03 PDT 
Created attachment 262533 [details]
Resetting binding tests
Comment 6 WebKit Commit Bot 2015-10-06 12:15:29 PDT 
Comment on attachment 262533 [details]
Resetting binding tests

Rejecting attachment 262533 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 262533, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/251358
Comment 7 youenn fablet 2015-10-06 12:18:12 PDT 
Created attachment 262535 [details]
Fixing OOPS
Comment 8 WebKit Commit Bot 2015-10-06 13:14:39 PDT 
Comment on attachment 262535 [details]
Fixing OOPS

Clearing flags on attachment: 262535

Committed r190637: <http://trac.webkit.org/changeset/190637>
Comment 9 WebKit Commit Bot 2015-10-06 13:14:45 PDT 
All reviewed patches have been landed.  Closing bug.