Bug 149720 - REGRESSION(r190370): Speedometer spits out an extra console message
Summary: REGRESSION(r190370): Speedometer spits out an extra console message
Status: RESOLVED DUPLICATE of bug 149621
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-10-01 13:11 PDT by Ryosuke Niwa
Modified: 2015-10-06 12:17 PDT (History)
6 users (show)

See Also:


Attachments
Screenshot of Mavericks perf bot builds list (347.47 KB, image/png)
2015-10-01 13:12 PDT, Ryosuke Niwa
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-10-01 13:11:54 PDT
run-perf-tests Speedometer fails with the following error message:

Running Speedometer/Full.html (1 of 1)
ERROR: CONSOLE MESSAGE: line 208: Miss the info bar? Run TodoMVC from a server to avoid a cross-origin error.
FAILED
Finished: 30.388546 s

Either r190370 fixed an existing bug or introduced a new regression.
Comment 1 Ryosuke Niwa 2015-10-01 13:12:25 PDT
Created attachment 262280 [details]
Screenshot of Mavericks perf bot builds list
Comment 2 Ryosuke Niwa 2015-10-01 13:12:50 PDT
The regression went away when we rolled out the patch so I'm pretty certain this is the culprit.
Comment 3 Ryosuke Niwa 2015-10-02 17:51:02 PDT
Committed r190535: <http://trac.webkit.org/changeset/190535>
Comment 4 Ryosuke Niwa 2015-10-02 17:51:18 PDT
Temporarily ignored this console message.
Comment 5 Csaba Osztrogonác 2015-10-06 02:46:06 PDT
(In reply to comment #4)
> Temporarily ignored this console message.

I think it is paper overing this serious regression. Why is it 
good to measure the performace if the test is completely broken?
Comment 6 Csaba Osztrogonác 2015-10-06 02:46:39 PDT

*** This bug has been marked as a duplicate of bug 149621 ***
Comment 7 Ryosuke Niwa 2015-10-06 11:57:41 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > Temporarily ignored this console message.
> 
> I think it is paper overing this serious regression. Why is it 
> good to measure the performace if the test is completely broken?

I don't think this is a serious regression. Tail optimization does change the JS behavior, and the benchmark isn't failing on the browser. It's just that we have one extra console message when ran inside WRT.
Comment 8 Csaba Osztrogonác 2015-10-06 12:03:27 PDT
(In reply to comment #7)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > Temporarily ignored this console message.
> > 
> > I think it is paper overing this serious regression. Why is it 
> > good to measure the performace if the test is completely broken?
> 
> I don't think this is a serious regression. Tail optimization does change
> the JS behavior, and the benchmark isn't failing on the browser. It's just
> that we have one extra console message when ran inside WRT.

I don't know the internals of this test. But theoretically I don't think 
if a JS engine should change the behaviour of any JS script anytime.
Comment 9 Ryosuke Niwa 2015-10-06 12:15:51 PDT
Wait, this isn't a duplicate of 149621.
Comment 10 Radar WebKit Bug Importer 2015-10-06 12:16:08 PDT
<rdar://problem/22995488>
Comment 11 Radar WebKit Bug Importer 2015-10-06 12:16:17 PDT
<rdar://problem/22995494>
Comment 12 Ryosuke Niwa 2015-10-06 12:17:04 PDT
Oh, nvm. I misread it.

*** This bug has been marked as a duplicate of bug 149621 ***
Comment 13 Radar WebKit Bug Importer 2015-10-06 12:17:28 PDT
<rdar://problem/22995514>