Bug 149670 – [Streams API] Update readable-stream-templated tests to latest spec

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Xabier Rodríguez Calvar]

This will break the tests because the spec has changed, but tests should come first.

[Xabier Rodríguez Calvar]

Created attachment 262166 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 262166 [details]
Patch

We could get a r+ and land now.

The idea is getting the tests landed so that the implementation can be changed according the new spec that these tests already follow in a test driven development manner.

[WebKit Commit Bot]

Comment on attachment 262166 [details]
Patch

Rejecting attachment 262166 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 262166, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
unk #2 FAILED at 20.
Hunk #3 FAILED at 42.
Hunk #4 succeeded at 58 with fuzz 2.
Hunk #5 succeeded at 72 with fuzz 1.
2 out of 6 hunks FAILED -- saving rejects to file LayoutTests/streams/reference-implementation/readable-stream-templated-expected.txt.rej
patching file LayoutTests/streams/reference-implementation/readable-stream-templated.html

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/307734

[Xabier Rodríguez Calvar]

Created attachment 263560 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 263560 [details]
Patch for landing

Clearing flags on attachment: 263560

Committed r191337: <http://trac.webkit.org/changeset/191337>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.