https://trac.webkit.org/changeset/190192 broke the build on ARM Linux: ../../Source/WebCore/platform/graphics/FontFeatureSettings.h: In static member function âstatic void WebCore::FontFeatureTagHashTraits::constructDeletedValue(WebCore::FontFeatureTag&)â: ../../Source/WebCore/platform/graphics/FontFeatureSettings.h:50:134: error: narrowing conversion of -1 from int to char inside { } [-Werror=narrowing] static void constructDeletedValue(FontFeatureTag& slot) { new (NotNull, std::addressof(slot)) FontFeatureTag({{ -1, -1, -1, -1 }}); } The root of the problem is that char is unsigned on ARM.
Created attachment 262057 [details] Patch
Created attachment 262060 [details] Patch
Created attachment 262061 [details] Patch
Comment on attachment 262061 [details] Patch A little messy; would be nice to have a named constant for static_cast<char>(0xFF) to avoid repeating it so many times. But seems fine.
Created attachment 262245 [details] patch for landing
Comment on attachment 262245 [details] patch for landing Clearing flags on attachment: 262245 Committed r190402: <http://trac.webkit.org/changeset/190402>