Bug 149552 - Clean up all uses of PassRefPtr in Modules/geolocation
Summary: Clean up all uses of PassRefPtr in Modules/geolocation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 144092
  Show dependency treegraph
 
Reported: 2015-09-25 01:00 PDT by Gyuyoung Kim
Modified: 2015-10-01 00:23 PDT (History)
2 users (show)

See Also:


Attachments
Patch (13.80 KB, patch)
2015-09-25 01:01 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (13.88 KB, patch)
2015-09-30 21:33 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-09-25 01:00:07 PDT
SSIA
Comment 1 Gyuyoung Kim 2015-09-25 01:01:03 PDT
Created attachment 261917 [details]
Patch
Comment 2 Darin Adler 2015-09-30 21:19:05 PDT
Comment on attachment 261917 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261917&action=review

> Source/WebCore/Modules/geolocation/Geoposition.h:45
>          return Geoposition::create(m_coordinates->isolatedCopy(), m_timestamp);

Could just be create, not Geoposition::create.
Comment 3 Gyuyoung Kim 2015-09-30 21:33:23 PDT
Created attachment 262229 [details]
Patch
Comment 4 Gyuyoung Kim 2015-09-30 23:35:53 PDT
(In reply to comment #2)
> Comment on attachment 261917 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261917&action=review
> 
> > Source/WebCore/Modules/geolocation/Geoposition.h:45
> >          return Geoposition::create(m_coordinates->isolatedCopy(), m_timestamp);
> 
> Could just be create, not Geoposition::create.

Thanks. Done.
Comment 5 WebKit Commit Bot 2015-10-01 00:23:17 PDT
Comment on attachment 262229 [details]
Patch

Clearing flags on attachment: 262229

Committed r190391: <http://trac.webkit.org/changeset/190391>
Comment 6 WebKit Commit Bot 2015-10-01 00:23:21 PDT
All reviewed patches have been landed.  Closing bug.