Bug 149446 - Split author style code out from DocumentStyleSheetCollection
Summary: Split author style code out from DocumentStyleSheetCollection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 149230
  Show dependency tree / graph
 
Reported: 2015-09-21 21:30 PDT by Antti Koivisto
Modified: 2015-09-25 14:59 PDT (History)
3 users (show)

See Also:

Attachments
patch (207.47 KB, patch)
2015-09-22 21:33 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (216.61 KB, patch)
2015-09-22 23:55 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-09-21 21:30:37 PDT 
Shadow trees may have their own author style. Factor the related code out so we can use it outside document context.
Comment 1 Antti Koivisto 2015-09-22 21:33:16 PDT 
Created attachment 261794 [details]
patch
Comment 2 Antti Koivisto 2015-09-22 21:38:28 PDT 
The patch is large because copy-moves, not because it changes that much.
Comment 3 Antti Koivisto 2015-09-22 23:55:57 PDT 
Created attachment 261800 [details]
patch
Comment 4 WebKit Commit Bot 2015-09-22 23:59:17 PDT 
Attachment 261800 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/DOMAllInOne.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Andreas Kling 2015-09-23 04:31:58 PDT 
Comment on attachment 261800 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261800&action=review

r=me

> Source/WebCore/ChangeLog:14
> +        AuthorStyleSheets - author stylesheets and optimization code
> +        ExtensionStyleSheets - user stylesheets, injected author stylesheets, content extension stylesheets

This is a nice split.

> Source/WebCore/dom/AuthorStyleSheets.cpp:65
> +    , m_pendingStylesheets(0)
> +    , m_injectedStyleSheetCacheValid(false)
> +    , m_hadActiveLoadingStylesheet(false)
> +    , m_pendingUpdateType(NoUpdate)
> +    , m_usesFirstLineRules(false)
> +    , m_usesFirstLetterRules(false)
> +    , m_usesRemUnits(false)
> +    , m_usesStyleBasedEditability(false)

You know where we could do all this instead? :)
Comment 6 Antti Koivisto 2015-09-23 08:05:29 PDT 
https://webkit.org/b/149446