WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149230
Implement scoped styling for shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=149230
Summary
Implement scoped styling for shadow DOM
Ryosuke Niwa
Reported
2015-09-16 14:13:57 PDT
Style rules defined or imported inside a shadow tree should only allow to nodes in that shadow tree.
Attachments
patch
(18.64 KB, patch)
2015-09-25 01:08 PDT
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
patch
(18.67 KB, patch)
2015-09-25 14:28 PDT
,
Antti Koivisto
rniwa
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2015-09-16 14:14:33 PDT
<
rdar://problem/22727059
>
Ryosuke Niwa
Comment 2
2015-09-21 18:12:27 PDT
***
Bug 149328
has been marked as a duplicate of this bug. ***
Antti Koivisto
Comment 3
2015-09-25 01:08:46 PDT
Created
attachment 261918
[details]
patch
Antti Koivisto
Comment 4
2015-09-25 14:28:07 PDT
Created
attachment 261939
[details]
patch
Ryosuke Niwa
Comment 5
2015-09-25 14:32:40 PDT
Comment on
attachment 261939
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=261939&action=review
> Source/WebCore/dom/ShadowRoot.cpp:84 > + // We could share style resolver with shadow roots that have identical style.
Should this be a FIXME?
Antti Koivisto
Comment 6
2015-09-25 15:06:43 PDT
https://trac.webkit.org/r190256
Alexey Proskuryakov
Comment 7
2015-09-25 23:16:31 PDT
There is a number of tests in platform/mac/TestExpectations that are marked as being tracked by a duplicate of this bug. Please unmark them if they are expected to pass now:
webkit.org/b/149328
fast/shadow-dom/css-scoping-shadow-host-rule.html [ ImageOnlyFailure ]
webkit.org/b/149328
fast/shadow-dom/css-scoping-shadow-host-functional-rule.html [ ImageOnlyFailure ]
webkit.org/b/149328
fast/shadow-dom/css-scoping-shadow-slotted-rule.html [ ImageOnlyFailure ]
webkit.org/b/149328
fast/shadow-dom/css-scoping-shadow-slot-display-override.html [ ImageOnlyFailure ]
webkit.org/b/149328
fast/shadow-dom/shadow-layout-after-slot-changes.html [ ImageOnlyFailure ]
Ryosuke Niwa
Comment 8
2015-09-25 23:41:58 PDT
(In reply to
comment #7
)
> There is a number of tests in platform/mac/TestExpectations that are marked > as being tracked by a duplicate of this bug. Please unmark them if they are > expected to pass now: > >
webkit.org/b/149328
fast/shadow-dom/css-scoping-shadow-host-rule.html [ > ImageOnlyFailure ] >
webkit.org/b/149328
> fast/shadow-dom/css-scoping-shadow-host-functional-rule.html [ > ImageOnlyFailure ] >
webkit.org/b/149328
fast/shadow-dom/css-scoping-shadow-slotted-rule.html [ > ImageOnlyFailure ] >
webkit.org/b/149328
> fast/shadow-dom/css-scoping-shadow-slot-display-override.html [ > ImageOnlyFailure ] >
webkit.org/b/149328
fast/shadow-dom/shadow-layout-after-slot-changes.html [ > ImageOnlyFailure ]
Oh oops, these are tracked by different bugs. Will update soon. Thanks for noticing that.
Ryosuke Niwa
Comment 9
2015-09-28 00:50:54 PDT
Done that in
https://trac.webkit.org/changeset/190275
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug