Bug 149400 - Fix the !ENABLE(TEMPLATE_ELEMENT) build after r189945
Summary: Fix the !ENABLE(TEMPLATE_ELEMENT) build after r189945
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 149286
  Show dependency tree / graph
 
Reported: 2015-09-21 03:33 PDT by Csaba Osztrogonác
Modified: 2015-09-21 12:16 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.33 KB, patch)
2015-09-21 03:34 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-09-21 03:33:53 PDT 
https://trac.webkit.org/changeset/189945/trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp
updated only the ENABLE(TEMPLATE_ELEMENT) case, but we should update the else case too.

build log:
-----------
../../Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp: In member function 'void WebCore::XMLDocumentParser::startElementNs(const xmlChar*, const xmlChar*, const xmlChar*, int, const xmlChar**, int, int, const xmlChar**)':
../../Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:856:37: error: no matching function for call to 'WebCore::XMLDocumentParser::pushCurrentNode(WebCore::Element&)'
../../Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:856:37: note: candidate is:
In file included from ../../Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:29:0:
../../Source/WebCore/xml/parser/XMLDocumentParser.h:143:14: note: void WebCore::XMLDocumentParser::pushCurrentNode(WebCore::ContainerNode*)
../../Source/WebCore/xml/parser/XMLDocumentParser.h:143:14: note:   no known conversion for argument 1 from 'WebCore::Element' to 'WebCore::ContainerNode*'
Comment 1 Csaba Osztrogonác 2015-09-21 03:34:59 PDT 
Created attachment 261644 [details]
Patch
Comment 2 WebKit Commit Bot 2015-09-21 12:16:14 PDT 
Comment on attachment 261644 [details]
Patch

Clearing flags on attachment: 261644

Committed r190068: <http://trac.webkit.org/changeset/190068>
Comment 3 WebKit Commit Bot 2015-09-21 12:16:18 PDT 
All reviewed patches have been landed.  Closing bug.