Bug 149286 - De-template ContainerNodeAlgorithms
Summary: De-template ContainerNodeAlgorithms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 149400
Blocks:
  Show dependency treegraph
 
Reported: 2015-09-17 14:18 PDT by Antti Koivisto
Modified: 2015-09-21 03:33 PDT (History)
8 users (show)

See Also:


Attachments
patch (29.63 KB, patch)
2015-09-17 14:32 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-09-17 14:18:13 PDT
This is pointlessly generic.
Comment 1 Antti Koivisto 2015-09-17 14:32:10 PDT
Created attachment 261425 [details]
patch
Comment 2 Andreas Kling 2015-09-17 16:29:33 PDT
Comment on attachment 261425 [details]
patch

Nice. Next make it iterative? :)
Comment 3 Antti Koivisto 2015-09-17 16:54:33 PDT
http://trac.webkit.org/changeset/189945
Comment 4 Darin Adler 2015-09-19 15:15:36 PDT
Comment on attachment 261425 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261425&action=review

> Source/WebCore/html/track/WebVTTParser.cpp:544
> +        auto child = Text::create(document, m_token.characters());
> +        m_currentNode->parserAppendChild(WTF::move(child));

If we did it on one line without the local variable then we wouldn’t need to call WTF::move.

> Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:1031
> +    auto newNode = CDATASection::create(m_currentNode->document(), toString(s, len));
> +    m_currentNode->parserAppendChild(WTF::move(newNode));

If we did it on one line without the local variable then we wouldn’t need to call WTF::move.

> Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:1047
> +    auto newNode = Comment::create(m_currentNode->document(), toString(s));
> +    m_currentNode->parserAppendChild(WTF::move(newNode));

If we did it on one line without the local variable then we wouldn’t need to call WTF::move.