Bug 149389 - [OS X] Update for Xcode 7.0 on Yosemite
Summary: [OS X] Update for Xcode 7.0 on Yosemite
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
: 149357 (view as bug list)
Depends on:
Reported: 2015-09-20 12:24 PDT by Myles C. Maxfield
Modified: 2015-09-23 22:21 PDT (History)
4 users (show)

See Also:

Patch (2.28 KB, patch)
2015-09-20 12:25 PDT, Myles C. Maxfield
ap: review-
Details | Formatted Diff | Diff
proposed fix (3.37 KB, patch)
2015-09-21 10:51 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-09-20 12:24:25 PDT
[OS X] Update for Xcode 7.0 on Yosemite
Comment 1 Myles C. Maxfield 2015-09-20 12:25:58 PDT
Created attachment 261610 [details]
Comment 2 Alexey Proskuryakov 2015-09-20 12:47:47 PDT
Comment on attachment 261610 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=261610&action=review

> Tools/DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:56
> -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100
>  @property (readonly) NSSpringLoadingHighlight springLoadingHighlight;
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100

springLoadingHighlight doesn't exist in NSDraggingInfo before El Capitan, so we shouldn't forward have on previous OS versions.

Could you please clarify what the problem is (perhaps e-mail me the full build log)? Are you building for Yosemite using El Capitan SDK?

> Tools/DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:57
>  - (void)resetSpringLoading;

Whatever we do, springLoadingHighlight and resetSpringLoading should be handled uniformly.
Comment 3 Alexey Proskuryakov 2015-09-21 10:51:12 PDT
Created attachment 261664 [details]
proposed fix

Discussed this with Mitz, who explained that the problem is that Xcode 7 for Yosemite ships with 10.11 SDK.
Comment 4 mitz 2015-09-21 11:55:07 PDT
Comment on attachment 261664 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=261664&action=review

> Tools/ChangeLog:15
> +        dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).

Seems OK for test code.
Comment 5 WebKit Commit Bot 2015-09-21 12:43:31 PDT
Comment on attachment 261664 [details]
proposed fix

Clearing flags on attachment: 261664

Committed r190070: <http://trac.webkit.org/changeset/190070>
Comment 6 WebKit Commit Bot 2015-09-21 12:43:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Alexey Proskuryakov 2015-09-23 22:21:51 PDT
*** Bug 149357 has been marked as a duplicate of this bug. ***