Bug 149357 - springLoadingHighlight is not automatically synthesized in Yosemite
Summary: springLoadingHighlight is not automatically synthesized in Yosemite
Status: RESOLVED DUPLICATE of bug 149389
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-18 15:56 PDT by Yusuke Suzuki
Modified: 2015-09-23 22:21 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.88 KB, patch)
2015-09-18 16:02 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2015-09-18 15:56:46 PDT 
SDK 10.11 introduces springLoadingHighlight. It is a objective-c property in a protocol.
It is marked as NS_AVAILABLE_MAC(10_11), but it exists.
As a result, if we build WebKit with 10.11 SDK in Yosemite, the following build failure occurs.

/Users/yusukesuzuki/development/Modules/Tools/WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:35:17: error: auto property synthesis will not
      synthesize property 'springLoadingHighlight' declared in protocol 'NSDraggingInfo' [-Werror,-Wobjc-protocol-property-synthesis]
@implementation WebKitTestRunnerDraggingInfo
                ^
In file included from /Users/yusukesuzuki/development/Modules/Tools/WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:1:
In file included from /Users/yusukesuzuki/development/Modules/Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h:30:
In file included from /Users/yusukesuzuki/development/Modules/WebKitBuild/new-int1/Release/WebKit.framework/PrivateHeaders/WebKit2_C.h:66:
In file included from /Users/yusukesuzuki/development/Modules/WebKitBuild/new-int1/Release/WebKit.framework/PrivateHeaders/WKView.h:30:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/Coco
a.framework/Headers/Cocoa.h:13:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/AppK
it.framework/Headers/AppKit.h:15:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/AppK
it.framework/Headers/NSActionCell.h:8:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/AppK
it.framework/Headers/NSCell.h:11:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/AppK
it.framework/Headers/NSText.h:8:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSView.h:18:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSDragging.h:101:47: note:
      property declared here
@property (readonly) NSSpringLoadingHighlight springLoadingHighlight NS_AVAILABLE_MAC(10_11);
                                              ^
1 error generated.
Comment 1 Yusuke Suzuki 2015-09-18 16:02:10 PDT 
Created attachment 261536 [details]
Patch
Comment 2 Yusuke Suzuki 2015-09-18 16:05:57 PDT 
Watching EWS......
Comment 3 Yusuke Suzuki 2015-09-18 16:32:41 PDT 
Comment on attachment 261536 [details]
Patch

Oops, build fails. OK, I'll add the switch based on the SDK version to workaround it...
Comment 4 Alexey Proskuryakov 2015-09-18 16:55:30 PDT 
> build WebKit with 10.11 SDK in Yosemite

Hmm, not sure if that's a supported configuration.
Comment 5 Yusuke Suzuki 2015-09-23 17:53:34 PDT 
(In reply to comment #4)
> > build WebKit with 10.11 SDK in Yosemite
> 
> Hmm, not sure if that's a supported configuration.

OK, so I'll change my environment :)
Comment 6 Alexey Proskuryakov 2015-09-23 22:21:51 PDT 
I'm sorry, I forgot about this report. This is a supported configuration, and I actually fixed this in another bug.

*** This bug has been marked as a duplicate of bug 149389 ***