Bug 149349 - line-break-language-sensitive tests should be marked as flaky
Summary: line-break-language-sensitive tests should be marked as flaky
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-18 12:03 PDT by Jake Nielsen
Modified: 2015-09-18 14:31 PDT (History)
2 users (show)

See Also:

Attachments
Marks appropriate tests as flaky. (929 bytes, patch)
2015-09-18 12:08 PDT, Jake Nielsen 		ap: commit-queue-
Details | Formatted Diff | Diff
Patch two (1.09 KB, patch)
2015-09-18 13:15 PDT, Jake Nielsen 		ddkilzer: review-
jake.nielsen.webkit: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jake Nielsen 2015-09-18 12:03:29 PDT 
More specifically, these four:
  css3/line-break-language-sensitive/line-break-loose-centered.html [ ImageOnlyFailure ]
  css3/line-break-language-sensitive/line-break-loose-postfixes.html [ ImageOnlyFailure ]
  css3/line-break-language-sensitive/line-break-loose-sound-marks.html [ ImageOnlyFailure ]
  css3/line-break-language-sensitive/line-break-normal-sound-marks.html [ ImageOnlyFailure ]
Comment 1 Jake Nielsen 2015-09-18 12:08:46 PDT 
Created attachment 261507 [details]
Marks appropriate tests as flaky.
Comment 2 Alexey Proskuryakov 2015-09-18 12:13:45 PDT 
Comment on attachment 261507 [details]
Marks appropriate tests as flaky.

View in context: https://bugs.webkit.org/attachment.cgi?id=261507&action=review

Looks good to me

> TestExpectations:2828
> +# Flaky tests

I'd put a comment mentioning bug 149320 here.
Comment 3 Alexey Proskuryakov 2015-09-18 12:14:21 PDT 
Comment on attachment 261507 [details]
Marks appropriate tests as flaky.

Oh wait, this should be in iOS expectations, not in the root.

platform/ios-simulator/TestExpectations
Comment 4 Jake Nielsen 2015-09-18 13:13:27 PDT 
(In reply to comment #3)
> Comment on attachment 261507 [details]
> Marks appropriate tests as flaky.
> 
> Oh wait, this should be in iOS expectations, not in the root.
> 
> platform/ios-simulator/TestExpectations

Ooops, my bad. I didn't generate the diff from the right directory
Comment 5 Jake Nielsen 2015-09-18 13:15:56 PDT 
Created attachment 261516 [details]
Patch two
Comment 6 David Kilzer (:ddkilzer) 2015-09-18 13:42:09 PDT 
Comment on attachment 261516 [details]
Patch two

This should really have a ChangeLog.
Comment 7 Myles C. Maxfield 2015-09-18 14:26:33 PDT 
For the long term, I should fix these tests instead of leaving them marked as flakey.
Comment 8 Myles C. Maxfield 2015-09-18 14:31:31 PDT 
Oh whoops, I misunderstood which tests these are. These tests should only run on particular versions of iOS, and on those versions, they should consistently pass.