More specifically, these four: css3/line-break-language-sensitive/line-break-loose-centered.html [ ImageOnlyFailure ] css3/line-break-language-sensitive/line-break-loose-postfixes.html [ ImageOnlyFailure ] css3/line-break-language-sensitive/line-break-loose-sound-marks.html [ ImageOnlyFailure ] css3/line-break-language-sensitive/line-break-normal-sound-marks.html [ ImageOnlyFailure ]
Created attachment 261507 [details] Marks appropriate tests as flaky.
Comment on attachment 261507 [details] Marks appropriate tests as flaky. View in context: https://bugs.webkit.org/attachment.cgi?id=261507&action=review Looks good to me > TestExpectations:2828 > +# Flaky tests I'd put a comment mentioning bug 149320 here.
Comment on attachment 261507 [details] Marks appropriate tests as flaky. Oh wait, this should be in iOS expectations, not in the root. platform/ios-simulator/TestExpectations
(In reply to comment #3) > Comment on attachment 261507 [details] > Marks appropriate tests as flaky. > > Oh wait, this should be in iOS expectations, not in the root. > > platform/ios-simulator/TestExpectations Ooops, my bad. I didn't generate the diff from the right directory
Created attachment 261516 [details] Patch two
Comment on attachment 261516 [details] Patch two This should really have a ChangeLog.
For the long term, I should fix these tests instead of leaving them marked as flakey.
Oh whoops, I misunderstood which tests these are. These tests should only run on particular versions of iOS, and on those versions, they should consistently pass.