WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149156
Remove all uses of PassRefPtr in WebCore/inspector
https://bugs.webkit.org/show_bug.cgi?id=149156
Summary
Remove all uses of PassRefPtr in WebCore/inspector
Gyuyoung Kim
Reported
2015-09-15 02:00:40 PDT
SSIA
Attachments
Patch
(29.90 KB, patch)
2015-09-15 02:01 PDT
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
Patch for landing
(30.05 KB, patch)
2015-09-16 18:56 PDT
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1
2015-09-15 02:01:18 PDT
Created
attachment 261180
[details]
Patch
Darin Adler
Comment 2
2015-09-16 09:50:32 PDT
Comment on
attachment 261180
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=261180&action=review
> Source/WebCore/inspector/TimelineRecordFactory.cpp:186 > +static RefPtr<InspectorArray> createQuad(const FloatQuad& quad)
Seems like it should return a Ref, not a RefPtr.
Gyuyoung Kim
Comment 3
2015-09-16 18:56:46 PDT
Created
attachment 261350
[details]
Patch for landing
WebKit Commit Bot
Comment 4
2015-09-16 22:40:17 PDT
Comment on
attachment 261350
[details]
Patch for landing Clearing flags on attachment: 261350 Committed
r189905
: <
http://trac.webkit.org/changeset/189905
>
WebKit Commit Bot
Comment 5
2015-09-16 22:40:21 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug