Bug 149156 - Remove all uses of PassRefPtr in WebCore/inspector
Summary: Remove all uses of PassRefPtr in WebCore/inspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 144092
  Show dependency treegraph
 
Reported: 2015-09-15 02:00 PDT by Gyuyoung Kim
Modified: 2015-09-16 22:40 PDT (History)
1 user (show)

See Also:


Attachments
Patch (29.90 KB, patch)
2015-09-15 02:01 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch for landing (30.05 KB, patch)
2015-09-16 18:56 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-09-15 02:00:40 PDT
SSIA
Comment 1 Gyuyoung Kim 2015-09-15 02:01:18 PDT
Created attachment 261180 [details]
Patch
Comment 2 Darin Adler 2015-09-16 09:50:32 PDT
Comment on attachment 261180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261180&action=review

> Source/WebCore/inspector/TimelineRecordFactory.cpp:186
> +static RefPtr<InspectorArray> createQuad(const FloatQuad& quad)

Seems like it should return a Ref, not a RefPtr.
Comment 3 Gyuyoung Kim 2015-09-16 18:56:46 PDT
Created attachment 261350 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2015-09-16 22:40:17 PDT
Comment on attachment 261350 [details]
Patch for landing

Clearing flags on attachment: 261350

Committed r189905: <http://trac.webkit.org/changeset/189905>
Comment 5 WebKit Commit Bot 2015-09-16 22:40:21 PDT
All reviewed patches have been landed.  Closing bug.