RESOLVED FIXED 149114
Remove all uses of PassRefPtr in WebCore/xml 
https://bugs.webkit.org/show_bug.cgi?id=149114
Summary Remove all uses of PassRefPtr in WebCore/xml
Gyuyoung Kim
Reported 2015-09-14 00:40:36 PDT
SSIA
Attachments
Patch (27.53 KB, patch)
2015-09-14 00:45 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (27.53 KB, patch)
2015-09-14 20:03 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-09-14 00:45:24 PDT
Created attachment 261107 [details] Patch
Darin Adler
Comment 2 2015-09-14 18:32:35 PDT
Comment on attachment 261107 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261107&action=review > Source/WebCore/xml/XPathValue.h:47 > + explicit Value(NodeSet value) Maybe this should take a NodeSet&&. > Source/WebCore/xml/XPathValue.h:53 > + explicit Value(RefPtr<Node> value) Maybe this should take a RefPtr&&. > Source/WebCore/xml/XPathValue.h:79 > + static Ref<Data> create(NodeSet nodeSet) { return adoptRef(*new Data(WTF::move(nodeSet))); } Maybe this should take a NodeSet&&. > Source/WebCore/xml/XPathValue.h:90 > + explicit Data(NodeSet nodeSet) Maybe this should take a NodeSet&&. > Source/WebCore/xml/XSLTProcessor.h:47 > + void setXSLStyleSheet(RefPtr<XSLStyleSheet> styleSheet) { m_stylesheet = WTF::move(styleSheet); } This should take either a RefPtr&& or just a raw pointer.
Gyuyoung Kim
Comment 3 2015-09-14 20:03:25 PDT
Created attachment 261163 [details] Patch
Gyuyoung Kim
Comment 4 2015-09-14 21:33:24 PDT
(In reply to comment #2) > Comment on attachment 261107 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261107&action=review > > > Source/WebCore/xml/XPathValue.h:47 > > + explicit Value(NodeSet value) > > Maybe this should take a NodeSet&&. > > > Source/WebCore/xml/XPathValue.h:53 > > + explicit Value(RefPtr<Node> value) > > Maybe this should take a RefPtr&&. > > > Source/WebCore/xml/XPathValue.h:79 > > + static Ref<Data> create(NodeSet nodeSet) { return adoptRef(*new Data(WTF::move(nodeSet))); } > > Maybe this should take a NodeSet&&. > > > Source/WebCore/xml/XPathValue.h:90 > > + explicit Data(NodeSet nodeSet) > > Maybe this should take a NodeSet&&. > > > Source/WebCore/xml/XSLTProcessor.h:47 > > + void setXSLStyleSheet(RefPtr<XSLStyleSheet> styleSheet) { m_stylesheet = WTF::move(styleSheet); } > > This should take either a RefPtr&& or just a raw pointer. All done. Thanks.
WebKit Commit Bot
Comment 5 2015-09-14 23:01:08 PDT
Comment on attachment 261163 [details] Patch Clearing flags on attachment: 261163 Committed r189776: <http://trac.webkit.org/changeset/189776>
WebKit Commit Bot
Comment 6 2015-09-14 23:01:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.