Bug 149091 - Remove all uses of PassRefPtr in crypto, storage, and history
Summary: Remove all uses of PassRefPtr in crypto, storage, and history
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
: 141760 (view as bug list)
Depends on:
Blocks: 144092
  Show dependency tree / graph
 
Reported: 2015-09-12 08:25 PDT by Gyuyoung Kim
Modified: 2022-04-14 23:44 PDT (History)
3 users (show)

See Also:

Attachments
Patch (28.63 KB, patch)
2015-09-12 08:34 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (28.61 KB, patch)
2015-09-13 18:08 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-09-12 08:25:34 PDT 
SSIA
Comment 1 Gyuyoung Kim 2015-09-12 08:34:18 PDT 
Created attachment 261055 [details]
Patch
Comment 2 Andreas Kling 2015-09-13 10:14:08 PDT 
Comment on attachment 261055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261055&action=review

> Source/WebCore/crypto/SubtleCrypto.h:41
> -    static PassRefPtr<SubtleCrypto> create(Document& document) { return adoptRef(new SubtleCrypto(document)); }
> +    static RefPtr<SubtleCrypto> create(Document& document) { return adoptRef(*new SubtleCrypto(document)); }

Should return Ref.

> Source/WebCore/storage/StorageMap.h:59
> -    PassRefPtr<StorageMap> copy();
> +    RefPtr<StorageMap> copy();

Should return Ref.
Comment 3 Gyuyoung Kim 2015-09-13 18:08:05 PDT 
Comment on attachment 261055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261055&action=review

>> Source/WebCore/crypto/SubtleCrypto.h:41
>> +    static RefPtr<SubtleCrypto> create(Document& document) { return adoptRef(*new SubtleCrypto(document)); }
> 
> Should return Ref.

Oops.

>> Source/WebCore/storage/StorageMap.h:59
>> +    RefPtr<StorageMap> copy();
> 
> Should return Ref.

done.
Comment 4 Gyuyoung Kim 2015-09-13 18:08:28 PDT 
Created attachment 261092 [details]
Patch
Comment 5 WebKit Commit Bot 2015-09-13 19:36:51 PDT 
Comment on attachment 261092 [details]
Patch

Clearing flags on attachment: 261092

Committed r189675: <http://trac.webkit.org/changeset/189675>
Comment 6 WebKit Commit Bot 2015-09-13 19:36:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Martin Robinson 2022-04-14 23:44:12 PDT 
*** Bug 141760 has been marked as a duplicate of this bug. ***