RESOLVED FIXED 149091
Remove all uses of PassRefPtr in crypto, storage, and history 
https://bugs.webkit.org/show_bug.cgi?id=149091
Summary Remove all uses of PassRefPtr in crypto, storage, and history
Gyuyoung Kim
Reported 2015-09-12 08:25:34 PDT
SSIA
Attachments
Patch (28.63 KB, patch)
2015-09-12 08:34 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (28.61 KB, patch)
2015-09-13 18:08 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-09-12 08:34:18 PDT
Created attachment 261055 [details] Patch
Andreas Kling
Comment 2 2015-09-13 10:14:08 PDT
Comment on attachment 261055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261055&action=review > Source/WebCore/crypto/SubtleCrypto.h:41 > - static PassRefPtr<SubtleCrypto> create(Document& document) { return adoptRef(new SubtleCrypto(document)); } > + static RefPtr<SubtleCrypto> create(Document& document) { return adoptRef(*new SubtleCrypto(document)); } Should return Ref. > Source/WebCore/storage/StorageMap.h:59 > - PassRefPtr<StorageMap> copy(); > + RefPtr<StorageMap> copy(); Should return Ref.
Gyuyoung Kim
Comment 3 2015-09-13 18:08:05 PDT
Comment on attachment 261055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261055&action=review >> Source/WebCore/crypto/SubtleCrypto.h:41 >> + static RefPtr<SubtleCrypto> create(Document& document) { return adoptRef(*new SubtleCrypto(document)); } > > Should return Ref. Oops. >> Source/WebCore/storage/StorageMap.h:59 >> + RefPtr<StorageMap> copy(); > > Should return Ref. done.
Gyuyoung Kim
Comment 4 2015-09-13 18:08:28 PDT
Created attachment 261092 [details] Patch
WebKit Commit Bot
Comment 5 2015-09-13 19:36:51 PDT
Comment on attachment 261092 [details] Patch Clearing flags on attachment: 261092 Committed r189675: <http://trac.webkit.org/changeset/189675>
WebKit Commit Bot
Comment 6 2015-09-13 19:36:55 PDT
All reviewed patches have been landed. Closing bug.
Martin Robinson
Comment 7 2022-04-14 23:44:12 PDT
*** Bug 141760 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.