Bug 149059 - Remove all uses of PassRefPtr in WebCore/accessibility and WebCore/fileapi
Summary: Remove all uses of PassRefPtr in WebCore/accessibility and WebCore/fileapi
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 144092
  Show dependency tree / graph
 
Reported: 2015-09-11 00:58 PDT by Gyuyoung Kim
Modified: 2015-09-12 01:46 PDT (History)
9 users (show)

See Also:

Attachments
Patch (11.13 KB, patch)
2015-09-11 00:59 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (11.76 KB, patch)
2015-09-11 23:05 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-09-11 00:58:18 PDT 
SSIA
Comment 1 Gyuyoung Kim 2015-09-11 00:59:57 PDT 
Created attachment 260993 [details]
Patch
Comment 2 Darin Adler 2015-09-11 09:09:11 PDT 
Comment on attachment 260993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260993&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:637
>      ASSERT(referenceRange);

An assertion like this indicates that the argument should be Range&, not Range*.
Comment 3 Gyuyoung Kim 2015-09-11 23:05:10 PDT 
Created attachment 261046 [details]
Patch
Comment 4 Gyuyoung Kim 2015-09-11 23:07:07 PDT 
Comment on attachment 260993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260993&action=review

>> Source/WebCore/accessibility/AccessibilityObject.cpp:637
>>      ASSERT(referenceRange);
> 
> An assertion like this indicates that the argument should be Range&, not Range*.

Yes, right. However referenceRange is already checked in 650 line. So I move it to here instead of the ASSERTION.
Comment 5 Gyuyoung Kim 2015-09-12 00:59:13 PDT 
Comment on attachment 261046 [details]
Patch

EFL EWS looks like false alarm. cq+ed.
Comment 6 WebKit Commit Bot 2015-09-12 01:46:03 PDT 
Comment on attachment 261046 [details]
Patch

Clearing flags on attachment: 261046

Committed r189650: <http://trac.webkit.org/changeset/189650>
Comment 7 WebKit Commit Bot 2015-09-12 01:46:08 PDT 
All reviewed patches have been landed.  Closing bug.