WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
148930
[WebGL] Return correct values for GL_STENCIL_VALUE_MASK and GL_STENCIL_WRITE_MASK
https://bugs.webkit.org/show_bug.cgi?id=148930
Summary
[WebGL] Return correct values for GL_STENCIL_VALUE_MASK and GL_STENCIL_WRITE_...
Jinyoung Hur
Reported
2015-09-07 07:12:10 PDT
n
Attachments
Patch
(4.10 KB, patch)
2015-09-07 07:22 PDT
,
Jinyoung Hur
dino
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jinyoung Hur
Comment 1
2015-09-07 07:14:26 PDT
It seems that ANGLE clamps GL_STENCIL_VALUE_MASK, GL_STENCIL_BACK_VALUE_MASK, GL_STENCIL_WRITEMASK and GL_STENCIL_BACK_WRITEMASK values into max integer, which results in the value change(0xffffffff --> 0x7fffffff) unintentionally.
Jinyoung Hur
Comment 2
2015-09-07 07:22:41 PDT
Created
attachment 260737
[details]
Patch
Jinyoung Hur
Comment 3
2015-09-07 07:35:19 PDT
Without this patch, fast/canvas/webgl/gl-get-calls.html fails on ANGLE backed OpenGL ES platform.
Dean Jackson
Comment 4
2015-09-10 11:08:19 PDT
Comment on
attachment 260737
[details]
Patch We can apply this in WebKit, but you really need the change to be made in ANGLE. Also, is there a way to test this?
Jinyoung Hur
Comment 5
2015-09-10 11:33:59 PDT
(In reply to
comment #4
)
> Comment on
attachment 260737
[details]
> Patch > > We can apply this in WebKit, but you really need the change to be made in > ANGLE. Also, is there a way to test this?
Ok then, I think it would be safe to commit this patch after landed on ANGLE project first. I believe there is no way to test this because no ports are using ANGLE as its OpenGL implementation but mine. My team's port is using ANGLE backed OpenGL APIs so I could find this bug. Anyway, thanks for review!
Jinyoung Hur
Comment 6
2015-09-15 11:42:11 PDT
ANGLE seems implemented correctly based on the OpenGL ES 3.0 spec. So this patch should be abandoned. Instead, I'm trying to modify fast/canvas/webgl/gl-get-calls.html at
https://bugs.webkit.org/show_bug.cgi?id=149174
Jinyoung Hur
Comment 7
2015-09-15 11:48:46 PDT
(In reply to
comment #6
)
> ANGLE seems implemented correctly based on the OpenGL ES 3.0 spec. > So this patch should be abandoned. > > Instead, I'm trying to modify fast/canvas/webgl/gl-get-calls.html at >
https://bugs.webkit.org/show_bug.cgi?id=149174
Review from an ANGLE people.
https://chromium-review.googlesource.com/#/c/299564/
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug