Bug 148927 – [EFL] Many of the css3/device-adapt/* tests failed after r188548.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Hunseop Jeong]

https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/24260/steps/layout-test/logs/stdio
  css3/device-adapt/opera/cascading-002.xhtml [ Failure ]
  css3/device-adapt/opera/cascading-003.xhtml [ Failure ]
  css3/device-adapt/opera/cascading-004.xhtml [ Failure ]
  css3/device-adapt/opera/constrain-001.xhtml [ Failure ]
  css3/device-adapt/opera/constrain-004.xhtml [ Failure ]
  css3/device-adapt/opera/constrain-005.xhtml [ Failure ]
  css3/device-adapt/opera/constrain-006.xhtml [ Failure ]
  css3/device-adapt/opera/constrain-007.xhtml [ Failure ]
  css3/device-adapt/opera/constrain-008.xhtml [ Failure ]
  css3/device-adapt/opera/constrain-010.xhtml [ Failure ]
  css3/device-adapt/opera/constrain-011.xhtml [ Failure ]
  css3/device-adapt/opera/constrain-013.xhtml [ Failure ]
  css3/device-adapt/opera/constrain-014.xhtml [ Failure ]
  css3/device-adapt/opera/constrain-015.xhtml [ Failure ]
  css3/device-adapt/opera/constrain-016.xhtml [ Failure ]
  css3/device-adapt/opera/constrain-017.xhtml [ Failure ]
  css3/device-adapt/opera/constrain-018.xhtml [ Failure ]
  css3/device-adapt/opera/constrain-019.xhtml [ Failure ]
  css3/device-adapt/opera/constrain-020.xhtml [ Failure ]
  css3/device-adapt/opera/syntax-001.xhtml [ Failure ]
  css3/device-adapt/opera/syntax-002.xhtml [ Failure ]
  css3/device-adapt/opera/syntax-003.xhtml [ Failure ]
  css3/device-adapt/viewport-width-check-window-innerwidth-correct.html [ Failure ]

[Hunseop Jeong]

Created attachment 260732 [details]
Patch

[Hunseop Jeong]

This patch is twice checking the 'if (test.urlContains("device-adapt/") || test.urlContains("device-adapt\\"))' in TestController and TestControllerEfl.
Do I move the check logic to TestController to remove the duplicated code?

[Csaba Osztrogonác]

Comment on attachment 260732 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260732&action=review

r=me

> Tools/ChangeLog:9
> +        overwritted by updatePlatformSpecificViewOptionsForTest after r188548.

typo: overwritten

> Tools/ChangeLog:14
> +        (WTR::shouldUseFixedLayout): Return the true if the test is related with 'device-adapt'.

nit: Please remove "the" before landing the patch. --> Return true ...

[Hunseop Jeong]

Created attachment 260733 [details]
Patch

[Hunseop Jeong]

(In reply to comment #3)
> Comment on attachment 260732 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260732&action=review
> 
> r=me
> 
> > Tools/ChangeLog:9
> > +        overwritted by updatePlatformSpecificViewOptionsForTest after r188548.
> 
> typo: overwritten
> 
> > Tools/ChangeLog:14
> > +        (WTR::shouldUseFixedLayout): Return the true if the test is related with 'device-adapt'.
> 
> nit: Please remove "the" before landing the patch. --> Return true ...

Oops... I fix the typo..

[Hunseop Jeong]

Your name looks like "Csaba Osztrogonác." in changeLog.
Do I make the new patch?

[Csaba Osztrogonác]

(In reply to comment #6)
> Your name looks like "Csaba Osztrogonác." in changeLog.
> Do I make the new patch?

No problem, it is a bug of the review tool, it will be 
good in the commit log and the change log after landing.

[WebKit Commit Bot]

Comment on attachment 260733 [details]
Patch

Clearing flags on attachment: 260733

Committed r189464: <http://trac.webkit.org/changeset/189464>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.